incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Checking release archive against VCS tag (was [VOTE] Release MRUnit version 0.8.0-incubating)
Date Thu, 12 Jan 2012 13:25:28 GMT
On 12 January 2012 12:35, Marvin Humphrey <marvin@rectangular.com> wrote:
> On Thu, Jan 12, 2012 at 12:26:49PM +0000, sebb wrote:
>> On 12 January 2012 12:08, Marvin Humphrey <marvin@rectangular.com> wrote:
>> > On Thu, Jan 12, 2012 at 11:37:18AM +0000, sebb wrote:
>> >> > How is this most easily accomplished? Checkout tag from SVN then
>> >> > manually diff against the artifact, or some other way is
>> >> > better/easier?
>> >>
>> >> I checkout the SVN tag and explode the archive(s) in the same parent
>> >> directory, and then use a Gui difference tool (WinDiff) to show the
>> >> differences.
>> >> Have to ignore SVN directories and (perhaps) EOL differences.
>> >
>> > I use "svn export" to avoid the .svn directories, then "diff -ur" on the Unix
>> > command line, optionally with "--strip-trailing-cr" when checking .zip
>> > archives.
>>
>> I also normally do a check on the SVN tag to verify that that
>> appropriate SVN properties have been set; that does not work on an
>> exported copy.
>> It's easy enough to ignore the SVN directories (especially since the
>> 1.7 change to the working copy format).
>
> What svn props do you look for?  I'm curious if I'm missing anything.
>
> There's eol-style of course, but that's per file, so there's no way I'm
> checking it on a giant source tree.

I don't check it manually!

> And the actual release archive is an "svn export"

Depends on the build process; it may be repacked from a clean checkout
of the tag.

> (all this assumes svn and not git of course), so whatever svn props
> were there, they're gone now!  It seems like svn props are a development
> issue rather than a release issue, no?

Yes, but if the eolstyle is missing or incorrect, it causes problems
when developers use OSes with different EOLs.
Not only can it make it harder for the developer to use the file, it
can also affect the SVN diff messages, showing diffs where there are
none.

Similarly if binary files don't have the correct mime-type; there have
been occasions when PDFs have been treated as text, which causes diff
messages to be huge and may cause some mail clients to bork.

> Besides, I don't actually care about line endings when performing this QC step
> -- I just want to see that the archive really was exported from the VCS tag.

There's no point for my use-case to both checkout the tag and export
it; once is enough.

> Marvin Humphrey
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message