Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of kevan.miller@gmail.com
 designates 209.85.161.175 as permitted sender)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Apple Message framework v1251.1)
Subject: Re: [VOTE] Release Kafka 0.7.0-incubating
From: Kevan Miller <kevan.miller@gmail.com>
In-Reply-To: 
 <CAOG_4QbGSsq6u847bZyA4zakM-Agv3qPc3ko_uuBwaOov2GT=A@mail.gmail.com>
Date: Thu, 17 Nov 2011 20:41:06 -0500
Content-Transfer-Encoding: quoted-printable
Message-Id: <FAC7DD21-D4CB-4F98-B73F-2E317FD96B36@gmail.com>
References: 
 <CAOG_4QbGSsq6u847bZyA4zakM-Agv3qPc3ko_uuBwaOov2GT=A@mail.gmail.com>
To: general@incubator.apache.org

I took a look at the svn source and the binary artifact and have some =
additional comments.

1) Your svn contains a number of jar files. I don't believe that the =
LICENSE/NOTICE file properly reflects the license/notice requirements of =
these jar files.=20
2) Why are these jars being stored in your svn at all?
3) Your LICENSE file only includes the ALv2 license. Yet your binary =
artifact (and your source) include artifacts with non-ALv2 licenses. For =
instance jopt-simple is MIT. All of the relevant licenses need to be =
included in your LICENSE file. You have the SCALA license in the notice =
file. I would expect it to be in the LICENSE file
4) Your NOTICE file includes lot's of "This product includes X, =
developed by X.org" Your notice file should only include notices that =
you are *required* to have. Don't include acknowledgements in your =
notice file just for completeness. Furthermore, when a notice is =
required, make sure it is accurate. For instance, ALv2 requires that you =
include a readable copy of the notices in the NOTICE file. If there =
isn't a NOTICE file, you should not provide a "notice". =
joda-time-1.6.jar includes a NOTICE file. It's content is:
"This product includes software developed by
Joda.org (http://www.joda.org/)."
That's what needs to be included in your NOTICE file. For differently =
licensed artifacts, you need to follow the requirements of their =
licenses.
BTW, it looks like hadoop and pig projects are distributing jars without =
license/notice files?
5) Your source/binary don't have a DISCLAIMER. An incubation disclaimer =
is required.

--kevan


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org