incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1203478 - /incubator/public/trunk/build.xml
Date Fri, 18 Nov 2011 12:23:58 GMT
On 18 November 2011 03:44,  <crossley@apache.org> wrote:
> Author: crossley
> Date: Fri Nov 18 03:44:37 2011
> New Revision: 1203478
>
> URL: http://svn.apache.org/viewvc?rev=1203478&view=rev
> Log:
> Remove the fixcrlf target (which was added in r463590 and r741205). I reckon that this
is now not needed, as the files now have correct "svn:eol-style" property.
> When people 'svn add' any new files, then be sure about http://apache.org/dev/version-control.html#https-svn-config

Are you sure it's not needed?

It does not fix source files, but generated files, and Anakia/Velocity
sometimes does funny things with EOLs.

I think it might be better to keep the target, but not invoke it automatically.
Then if problems do occur - e.g. cannot commit generated files because
of inconsistent line endings - it's easy to fix them.

> Modified:
>    incubator/public/trunk/build.xml
>
> Modified: incubator/public/trunk/build.xml
> URL: http://svn.apache.org/viewvc/incubator/public/trunk/build.xml?rev=1203478&r1=1203477&r2=1203478&view=diff
> ==============================================================================
> --- incubator/public/trunk/build.xml (original)
> +++ incubator/public/trunk/build.xml Fri Nov 18 03:44:37 2011
> @@ -91,15 +91,8 @@
>             </fileset>
>         </copy>
>        <copy file="${docs.src}/podlings.xml" tofile="${docs.dest}/podlings.xml"/>
> -        <antcall target="fix"></antcall>
> -
>     </target>
>
> -    <target name="fix">
> -        <echo message="Fix line endings due to inconsistent svn:eol-style properties
etc."/>
> -        <fixcrlf srcdir="${docs.dest}" includes="**/*.html"/>
> -    </target>
> -
>        <!--
>        Site map generation
>        -->
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cvs-unsubscribe@incubator.apache.org
> For additional commands, e-mail: cvs-help@incubator.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message