incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release for Bigtop version 0.1.0-incubating
Date Mon, 22 Aug 2011 17:54:08 GMT
On 22 August 2011 16:56, Benson Margulies <bimargulies@gmail.com> wrote:
> On Mon, Aug 22, 2011 at 11:26 AM, Andrew Bayer <andrew.bayer@gmail.com> wrote:
>> Whoops. Sorry about that. New tag created -
>> https://svn.apache.org/repos/asf/incubator/bigtop/tags/release-0.1.0-incubating-RC2
>>
>> A.
>>
>> On Mon, Aug 22, 2011 at 5:37 AM, sebb <sebbaz@gmail.com> wrote:
>>
>>> Tags are supposed to be immutable.
>
> Two points here.
>
> 1) It's a bad idea to do serious QA only as part of a release vote. It
> leads to a lot of noise and duplicated effort. Some of what led to a
> respin here could have been tested for before starting a vote.

+1
> 2) Sebb, I'm sorry to point out that labels are frequently mutated as
> part of the release process in various TLP's of which am a part. The
> typical procedure is:
>
> 1) Try very hard to sort out any possible problems.
> 2) Run maven-release-plugin. This creates a tag named after the
> proposed release (e.g. cxf-2.4).
> 3) Start vote.
> 3) If awful turns up, delete tag, goto 1.
>
> The problem is that maven metadata captures the actual svn path, so if
> you try to take the '-rcn and rename' you end up with poms with the
> wrong svn tags in them. So we're all stuck with not-quite-immutable
> tags.

It's still possible to have immutable tags for votes.

Tomcat creates tags of the form 7.0.n.
If the vote succeeds, good, then the code is released.
If not, then abandon the tag entirely, and restart with 7.0.n+1
Yes, it leaves occasional gaps in the release versions, but it is very
simple to operate.
[I think httpd do the same]

But if you don't want to do that, it's still possible to create a tag
with the -RCn suffix but the correct entries in the poms.

It may not be possible to do this using the Maven Release plugin, but
I don't use it so I don't know.

I create a clean workspace from trunk, edit poms to fix up version and
SVN URLs and then create the tag directly from the workspace.
The workspace is then ready to use to build the release candidate.

This leaves the trunk as a snapshot, as well being safer than working
from the local trunk workspace, which might contain spurious files.

If all else fails, make sure that the release vote includes the SVN
revision, because at least SVN revision + tag is immutable.

>>>
>>> For example, add an -RCn suffix which is removed (SVN copy or rename)
>>> when the vote succeeds.
>>>
>>> Failing that, please quote the revision number of the tag.
>>>
>>> Otherwise it's not possible to determine what was actually voted on.
>>>
>>> [BTW, the new tar file format reads OK in Winzip and Ant.]
>>>
>>> On 22 August 2011 01:56, Andrew Bayer <andrew.bayer@gmail.com> wrote:
>>> > Tag replaced.
>>> >
>>> > A.
>>> >
>>> > On Sun, Aug 21, 2011 at 5:26 PM, sebb <sebbaz@gmail.com> wrote:
>>> >
>>> >> On 22 August 2011 00:49, Andrew Bayer <andrew.bayer@gmail.com>
wrote:
>>> >> > New candidate up at
>>> >> > http://people.apache.org/~abayer/bigtop-0.1.0-incubating-candidate-2/
>>> .
>>> >> The
>>> >> > only files RAT still sees missing license headers are Debian packaging
>>> >> files
>>> >> > that are just lists of files, and test data files. README.md has
been
>>> >> > replaced with README. The gitignore files are, at least for now,
>>> excluded
>>> >> > from the tarball. The webpage has been updated. The tarball has
been
>>> >> built
>>> >> > with GNU tar, rather than BSD tar.
>>> >> >
>>> >> > Let me know if there are any more issues. Thanks!
>>> >>
>>> >> Can't find an SVN tag for the source.
>>> >>
>>> >> > A.
>>> >> >
>>> >> > On Sun, Aug 21, 2011 at 11:45 AM, Andrew Bayer <
>>> andrew.bayer@gmail.com
>>> >> >wrote:
>>> >> >
>>> >> >> The README is formatted for GitHub - will update that shortly.
The
>>> >> tarball
>>> >> >> contents being weird I think is due to me having built the
tar on OS
>>> X -
>>> >> >> I'll build the next one on a Linux box to be safe. I'll try
to get
>>> the
>>> >> files
>>> >> >> missing headers today as well.
>>> >> >>
>>> >> >> A.
>>> >> >>
>>> >> >>
>>> >> >> On Sat, Aug 20, 2011 at 4:28 AM, sebb <sebbaz@gmail.com>
wrote:
>>> >> >>
>>> >> >>> Just noticed that the README.md file contains the following:
>>> >> >>>
>>> >> >>> You can get in touch with us on the [user
>>> >> >>> list](
>>> >> https://groups.google.com/a/cloudera.org/group/bigtop-user/topics)
>>> >> >>> or [developer list](
>>> >> >>> https://groups.google.com/a/cloudera.org/group/bigtop-dev/topics).
>>> >> >>>
>>> >> >>> This also needs to be fixed before release.
>>> >> >>>
>>> >> >>> Why is this not a .txt file?
>>> >> >>>
>>> >> >>> On 20 August 2011 03:08, sebb <sebbaz@gmail.com>
wrote:
>>> >> >>> > On 19 August 2011 23:14, Andrew Bayer <andrew.bayer@gmail.com>
>>> >> wrote:
>>> >> >>> >> Ack, I screwed up and overwrote RC0 with RC1.
In any case, please
>>> >> find
>>> >> >>> RC1
>>> >> >>> >> at
>>> >> >>>
>>> http://people.apache.org/~abayer/bigtop-0.1.0-incubating-candidate-1/.
>>> >> >>> >
>>> >> >>> > NOTICE looks good, and I can see DISCLAIMER.
>>> >> >>> > Archive still contains .gitignore files, which should
be excluded.
>>> >> >>> >
>>> >> >>> >> Website should update shortly.
>>> >> >>> >
>>> >> >>> > No sign yet.
>>> >> >>> >
>>> >> >>> >> A.
>>> >> >>> >>
>>> >> >>> >> On Fri, Aug 19, 2011 at 3:00 PM, Andrew Bayer
<
>>> >> andrew.bayer@gmail.com
>>> >> >>> >wrote:
>>> >> >>> >>
>>> >> >>> >>> Oh, and I'm reformatting NOTICE now as well.
The .gitignore
>>> files -
>>> >> >>> I'll
>>> >> >>> >>> open a bug to remove the top-level one from
the tarball, but the
>>> >> ones
>>> >> >>> that
>>> >> >>> >>> show up deeper are expected by the build process.
>>> >> >>> >>>
>>> >> >>> >>>  A.
>>> >> >>> >>>
>>> >> >>> >>>
>>> >> >>> >>> On Fri, Aug 19, 2011 at 2:58 PM, Andrew Bayer
<
>>> >> andrew.bayer@gmail.com
>>> >> >>> >wrote:
>>> >> >>> >>>
>>> >> >>> >>>> Which source files are missing the headers?
I know there are
>>> some
>>> >> >>> files
>>> >> >>> >>>> without headers, but the ones I know of
are that way because
>>> >> they're
>>> >> >>> >>>> expected to be in certain formats, they
don't allow comments,
>>> etc
>>> >> -
>>> >> >>> these
>>> >> >>> >>>> should only be Debian/RPM packaging files,
unless I'm missing
>>> >> >>> something.
>>> >> >>> >>>>
>>> >> >>> >>>> As to the package contents - as far as
I can tell, everything
>>> is
>>> >> >>> under
>>> >> >>> >>>> bigtop-0.1.0-incubating. The contents
there are the same as in
>>> >> SVN,
>>> >> >>> same
>>> >> >>> >>>> layout as in SVN, etc. The content under
test is not yet being
>>> >> >>> built/used,
>>> >> >>> >>>> and may well be reorganized later, but
it's all there. If there
>>> >> are
>>> >> >>> any
>>> >> >>> >>>> inconsistencies with what's in SVN, let
me know and I'll check
>>> it
>>> >> >>> out.
>>> >> >>> >>>>
>>> >> >>> >>>> Adding DISCLAIMER now.
>>> >> >>> >>>>
>>> >> >>> >>>> A.
>>> >> >>> >>>>
>>> >> >>> >>>>
>>> >> >>> >>>> On Fri, Aug 19, 2011 at 2:48 PM, sebb
<sebbaz@gmail.com>
>>> wrote:
>>> >> >>> >>>>
>>> >> >>> >>>>> On 19 August 2011 19:25, Andrew Bayer
<andrew.bayer@gmail.com
>>> >
>>> >> >>> wrote:
>>> >> >>> >>>>> > This is the first incubator release
for Apache Bigtop,
>>> version
>>> >> >>> >>>>> > 0.1.0-incubating.
>>> >> >>> >>>>> >
>>> >> >>> >>>>> > It fixes the following issues:
>>> >> >>> >>>>> >
>>> >> >>> >>>>>
>>> >> >>>
>>> >>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12317549&styleName=Html&projectId=12311420
>>> >> >>> >>>>> >
>>> >> >>> >>>>> > *** Please download, test, and
vote by Wednesday, August 24
>>> (3
>>> >> >>> working
>>> >> >>> >>>>> days
>>> >> >>> >>>>> > from now)
>>> >> >>> >>>>> >
>>> >> >>> >>>>> > Note that we are voting on the
source (tag).
>>> >> >>> >>>>> >
>>> >> >>> >>>>> > Source tarball, checksums, signature:
>>> >> >>> >>>>> >
>>> >> >>>
>>> http://people.apache.org/~abayer/bigtop-0.1.0-incubating-candidate-0/
>>> >> >>> >>>>>
>>> >> >>> >>>>> A lot of source files don't have any
license headers.
>>> >> >>> >>>>> There's no DISCLAIMER in the archive;
needs also to be added
>>> to
>>> >> SVN
>>> >> >>> >>>>> alongside NOTICE and LICENSE.
>>> >> >>> >>>>>
>>> >> >>> >>>>> The DISCLAIMER text must also be prominently
displayed on the
>>> >> bigtop
>>> >> >>> >>>>> website.
>>> >> >>> >>>>>
>>> >> >>> >>>>> IMO these must be fixed before a release.
>>> >> >>> >>>>>
>>> >> >>> >>>>> The NOTICE file has a slightly different
layout from normal
>>> (not
>>> >> a
>>> >> >>> >>>>> blocker).
>>> >> >>> >>>>> It would look better if the paragraph
were wrapped after
>>> >> "developed
>>> >> >>> >>>>> at" - as is normally done - because
the URL would then not be
>>> >> left
>>> >> >>> >>>>> dangling.
>>> >> >>> >>>>>
>>> >> >>> >>>>> I would not expect the .gitignore
files to be included in the
>>> >> source
>>> >> >>> >>>>> release.
>>> >> >>> >>>>>
>>> >> >>> >>>>> There seems to be a problem with the
packaging of the archive
>>> - I
>>> >> >>> >>>>> would expect all files to be under
the top-level directory
>>> >> >>> >>>>> bigtop-0.1.0-incubating, but there
are also parallel
>>> directories
>>> >> >>> >>>>> package, sqoop, smokes etc.  This
makes it very difficult to
>>> >> check
>>> >> >>> the
>>> >> >>> >>>>> archive against the source archive.
>>> >> >>> >>>>>
>>> >> >>> >>>>> Again, I think this needs to be fixed
before release.
>>> >> >>> >>>>>
>>> >> >>> >>>>> > The tag to be voted on:
>>> >> >>> >>>>> >
>>> >> >>> >>>>>
>>> >> >>>
>>> >>
>>> http://svn.apache.org/repos/asf/incubator/bigtop/tags/release-0.1.0-incubating
>>> >> >>> >>>>>
>>> >> >>> >>>>> > Bigtop's KEYS file, containing
the PGP keys used to sign the
>>> >> >>> release:
>>> >> >>> >>>>> > http://svn.apache.org/repos/asf/incubator/bigtop/dist/KEYS
>>> >> >>> >>>>>
>>> >> >>> >>>>> sig is OK
>>> >> >>> >>>>>
>>> >> >>> >>>>> > Note that the Incubator PMC needs
to vote on the release
>>> after
>>> >> a
>>> >> >>> >>>>> successful
>>> >> >>> >>>>> > PPMC vote before any release
can be made official.
>>> >> >>> >>>>> >
>>> >> >>> >>>>> > Thanks!
>>> >> >>> >>>>> >
>>> >> >>> >>>>> > A.
>>> >> >>> >>>>> >
>>> >> >>> >>>>>
>>> >> >>> >>>>>
>>> >> >>>
>>> ---------------------------------------------------------------------
>>> >> >>> >>>>> To unsubscribe, e-mail:
>>> general-unsubscribe@incubator.apache.org
>>> >> >>> >>>>> For additional commands, e-mail:
>>> >> general-help@incubator.apache.org
>>> >> >>> >>>>>
>>> >> >>> >>>>>
>>> >> >>> >>>>
>>> >> >>> >>>
>>> >> >>> >>
>>> >> >>> >
>>> >> >>>
>>> >> >>>
>>> ---------------------------------------------------------------------
>>> >> >>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> >> >>> For additional commands, e-mail: general-help@incubator.apache.org
>>> >> >>>
>>> >> >>>
>>> >> >>
>>> >> >
>>> >>
>>> >
>>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message