incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release for Bigtop version 0.1.0-incubating
Date Sat, 20 Aug 2011 02:03:43 GMT
On 19 August 2011 22:58, Andrew Bayer <andrew.bayer@gmail.com> wrote:
> Which source files are missing the headers? I know there are some files
> without headers, but the ones I know of are that way because they're
> expected to be in certain formats, they don't allow comments, etc - these
> should only be Debian/RPM packaging files, unless I'm missing something.

There are several shell scripts, e.g.
hadoop-pig.postinst
hadoop-pig.preinst
src/pkg/deb/pig/rules

Other files that could and should have AL headers:
*.apt

SQL scripts such as
test/src/smokes/hive/src/test/resources/scripts/integration/hbase_joins/in
(it would not harm to include a description as well)

There may be others. I suggest running RAT to produce a report.

> As to the package contents - as far as I can tell, everything is under
> bigtop-0.1.0-incubating. The contents there are the same as in SVN, same
> layout as in SVN, etc. The content under test is not yet being built/used,
> and may well be reorganized later, but it's all there. If there are any
> inconsistencies with what's in SVN, let me know and I'll check it out.

There seems to a problem with reading the tar file using Winzip (and
in fact with Ant as well, which is what I use normally for
command-line unpacking). Some of the paths are missing some leading
segments.

I just tried using 7-Zip and that worked fine.
The archive matches the SVN tag once the unpacking is sorted out.

What exact command did you use to create the tar file?
It's clearly creating a file that confuses Winzip and Ant.

Maybe you can try using Ant to unpack the archive and see if you see
the same behaviour:

<?xml version="1.0"?>
<project name="unpack" default="unpack" basedir=".">
<property name="name" value="bigtop-0.1.0-incubating"/>
<target name="unpack">
    <gunzip src="${name}.tar.gz" dest="${name}.tar"/>
    <untar  src="${name}.tar" dest="${name}.tar-tgz"/>
    <delete file="${name}.tar"/>
</target>
</project>

I'm using Ant 1.8.2 on WinXP

> Adding DISCLAIMER now.
>
> A.
>
> On Fri, Aug 19, 2011 at 2:48 PM, sebb <sebbaz@gmail.com> wrote:
>
>> On 19 August 2011 19:25, Andrew Bayer <andrew.bayer@gmail.com> wrote:
>> > This is the first incubator release for Apache Bigtop, version
>> > 0.1.0-incubating.
>> >
>> > It fixes the following issues:
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12317549&styleName=Html&projectId=12311420
>> >
>> > *** Please download, test, and vote by Wednesday, August 24 (3 working
>> days
>> > from now)
>> >
>> > Note that we are voting on the source (tag).
>> >
>> > Source tarball, checksums, signature:
>> > http://people.apache.org/~abayer/bigtop-0.1.0-incubating-candidate-0/
>>
>> A lot of source files don't have any license headers.
>> There's no DISCLAIMER in the archive; needs also to be added to SVN
>> alongside NOTICE and LICENSE.
>>
>> The DISCLAIMER text must also be prominently displayed on the bigtop
>> website.
>>
>> IMO these must be fixed before a release.
>>
>> The NOTICE file has a slightly different layout from normal (not a
>> blocker).
>> It would look better if the paragraph were wrapped after "developed
>> at" - as is normally done - because the URL would then not be left
>> dangling.
>>
>> I would not expect the .gitignore files to be included in the source
>> release.
>>
>> There seems to be a problem with the packaging of the archive - I
>> would expect all files to be under the top-level directory
>> bigtop-0.1.0-incubating, but there are also parallel directories
>> package, sqoop, smokes etc.  This makes it very difficult to check the
>> archive against the source archive.
>>
>> Again, I think this needs to be fixed before release.
>>
>> > The tag to be voted on:
>> >
>> http://svn.apache.org/repos/asf/incubator/bigtop/tags/release-0.1.0-incubating
>>
>> > Bigtop's KEYS file, containing the PGP keys used to sign the release:
>> > http://svn.apache.org/repos/asf/incubator/bigtop/dist/KEYS
>>
>> sig is OK
>>
>> > Note that the Incubator PMC needs to vote on the release after a
>> successful
>> > PPMC vote before any release can be made official.
>> >
>> > Thanks!
>> >
>> > A.
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message