incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Apache Isis release candidate 0.1.2-RC4-incubating
Date Thu, 23 Jun 2011 12:54:10 GMT
On 23 June 2011 10:37, Mark Struberg <struberg@yahoo.de> wrote:
>
> Hi Sebb!
>
> Txs for catching this!
>
> Just to make sure we are looking at the same source distribution. I took the one I reviewed
from here:
>
> https://repository.apache.org/content/repositories/orgapacheisis-070/org/apache/isis/isis/0.1.2-RC4-incubating/isis-0.1.2-RC4-incubating-source-release.zip

I thought I had used the one from the e-mail:

http://people.apache.org/~danhaywood/isis-0.1.2-RC4-incubating-source-release.zip

but it turns out I used the later file from the same directory:

http://people.apache.org/~danhaywood/isis-incubating-source-release.zip

Oops - sorry about that.

However, the problem still exists - the source archive from the home
directory as listed in the e-mail contains lots of entries that don't
belong there.

What's even more serious is that the Maven version of the source
archive that you used is not the same as the source archive listed in
the e-mail.
They have different sigs and hashes.

This means that you may not all have voted on the same artifacts.
IMO, that invalidates any votes.

There is a further problem.

The Maven repo source archive only has one extra file - NOTICE - which
is not in the SVN tag.
Easily fixed by adding NOTICE to SVN (which should be there anyway).

So I can see why you were curious about what archive I had used ...

However the POM files disagree with the SVN tag.

0.1.2-RC4-incubating - Maven source archive
0.1.2-incubating - SVN tag

The other POMs in the Maven directory contain version ids of
0.1.2-RC4-incubating which I think will cause problems if they are
deployed.

I would expect to see one source archive (packaged as zip and usually
tar.gz), which should agree with the files in the SVN tag.

The POMs in the Maven staging area should also agree with the SVN tag

I think the packaging needs to be fixed before the release can be made.

> Please note that a few files will be created automatically on the fly (MANIFEST with
correct entries) thus they do not exist in SVN.

This is not actually a problem with the Maven version of the source archive.
It is a problem with the version from Dan's home directory.

> I think the problem with the NOTICE files is caused by maven using the project.name for
both the menu in the site and the title in the NOTICE file. Thus you can choose between a
broken menu (way too long text) and a broken NOTICE file (way to less text) :)
>
> I think we should add the NOTICE files to each and every sub module. Afaik maven doesn't
generate them anymore in that case.

No idea, sorry.

> LieGrue,
> strub
>
>
> --- On Thu, 6/23/11, sebb <sebbaz@gmail.com> wrote:
>
>> From: sebb <sebbaz@gmail.com>
>> Subject: Re: [VOTE] Apache Isis release candidate 0.1.2-RC4-incubating
>> To: general@incubator.apache.org
>> Date: Thursday, June 23, 2011, 1:25 AM
>> On 22 June 2011 06:04, dan haywood
>> <dan@haywood-associates.co.uk>
>> wrote:
>> > This is the first release of Apache Isis
>> (incubating).
>> > We have already received 3 binding IPMC votes during
>> the PPMC voting
>> > [1,2], so I'm requesting a 72 hour lazy consensus
>> before releasing
>> > the artifacts.
>> > Please vote now.
>> > [ ] +1
>> > [ ] 0
>> > [ ] -1
>> > Many thanks
>> > Dan Haywood
>> > [1]
>> > http://mail-archives.apache.org/mod_mbox/incubator-isis-dev/201106.mbox/%3C4DFEFA3E.4060409@gmail.com%3E
>> > [2]
>> > http://mail-archives.apache.org/mod_mbox/incubator-isis-dev/201106.mbox/%3C4E003820.6010803@gmail.com%3E
>> >
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> > [quote from="isis-dev" reason='to help you validate
>> the artifacts yourself
>> > if you wish']
>> >
>> > I've staged a release candidate for Apache Isis,
>> > namely 0.1.2-RC4-incubating.
>>
>> There's no NOTICE file at the top-level of the tag; it
>> should appear
>> alongside the LICENSE file.
>>
>> It does appear in the source archive, which is supposed to
>> be derived
>> from SVN...
>>
>> > This release candidate removes the dependency on XOM
>> (an LGPL library).  It
>> > also upgrades another dependency (RestEasy) from an
>> older version that was
>> > LGPL to a new version that is licensed under ALv2.
>> > Note also that the DEPENDENCIES file (in the root of
>> the source ZIP) also
>> > now correctly aggregates dependencies on all modules
>> and submodules that
>> > make up the release.
>> > The signed source ZIP can be downloaded from my home
>> directory on
>> > people.apache.org:
>> > *
>> > http://people.apache.org/~danhaywood/isis-0.1.2-RC4-incubating-source-release.zip (zip
>> > file), and
>>
>> The source archive contains lots of files that don't appear
>> to be in
>> SVN, including log files and some class files.
>> Also lots of META-INF dirs and MANIFEST.MF files. These
>> should not be present.
>>
>> Something has gone wrong with the packaging.
>>
>> > http://people.apache.org/~danhaywood/isis-0.1.2-RC4-incubating-source-release.zip.asc (signature)
>> > The code has been tagged as
>> tags/0.1.2-RC4-incubating.
>> > In addition, the Maven artifacts have been staged to
>> staging repository on
>> > repository.apache.org:
>> > * https://repository.apache.org/content/repositories/orgapacheisis-070/
>>
>> The NOTICE files in the jars don't have the correct project
>> name - the
>> Apache prefix is missing.
>> For example, the file in
>> applib-0.1.2-RC4-incubating-sources.jar says:
>>
>> Isis AppLib
>>
>> it should be
>>
>> Apache Isis Applib
>>
>> And groovy-applib-0.1.2-RC4-incubating-javadoc.jar NOTICE
>> says
>>
>> Groovy ProgModel AppLib
>>
>> which does not even include Isis!
>>
>> > I've also uploaded a new version of the site at
>> > http://incubator.apache.org/isis-0.1.2-RC4-incubating.
>>  The contributors
>> > guide on the site contains some suggestions of how to
>> verify the release,
>> > see http://incubator.apache.org/isis-0.1.2-RC4-incubating/docbkx/html/guide/ch12s06.html
>> > [/quote]
>> >
>> > ---------- Forwarded message ----------
>> > From: Dan Haywood <dkhaywood@gmail.com>
>> > Date: 21 June 2011 07:20
>> > Subject: Re: [VOTE] [RESULT] Apache Isis release
>> candidate
>> > 0.1.2-RC4-incubating
>> > To: isis-dev@incubator.apache.org
>> >
>> >
>> > The vote results (in full) are:
>> >
>> > 6 +1 votes: struberg*, bimargulies*, sgoeschl*,
>> danhaywood, kevin, rmatthews
>> > no +0 votes
>> > no -1 votes
>> >
>> > There were the required +3 votes by members (*)'d.
>> >
>> > Thanks
>> > Dan
>> >
>> >
>> > On 20/06/2011 10:09, Mark Struberg wrote:
>> >>
>> >> Hi Dan!
>> >>
>> >> It's usus to explicitly list the names (or
>> apacheids) of those who voted.
>> >> Just to make it a bit easier to control. Could you
>> please add those?
>> >>
>> >> txs and LieGrue,
>> >> strub
>> >>
>> >> --- On Mon, 6/20/11, Dan Haywood<dkhaywood@gmail.com>
>>  wrote:
>> >>
>> >>> From: Dan Haywood<dkhaywood@gmail.com>
>> >>> Subject: [VOTE] [RESULT] Apache Isis release
>> candidate
>> >>> 0.1.2-RC4-incubating
>> >>> To: isis-dev@incubator.apache.org
>> >>> Date: Monday, June 20, 2011, 7:43 AM
>> >>> This vote is now closed, and has
>> >>> passed:
>> >>>
>> >>> 6 +1 votes (+3 from members).
>> >>> No 0 votes
>> >>> No -1 votes.
>> >>>
>> >>> I am now going to cut the final release
>> (0.1.2-incubating)
>> >>> from the same revision, and will request a
>> lazy consensus
>> >>> vote on general@incubator.a.o
>> >>> for the final release.
>> >>>
>> >>> Thanks, all
>> >>> Dan
>> >>>
>> >>>
>> >>>
>> >
>> >
>> >
>> >
>> ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: general-help@incubator.apache.org
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message