incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marvin Humphrey <mar...@rectangular.com>
Subject Re: [VOTE] Release Droids 0.1-incubating RC2
Date Wed, 15 Jun 2011 01:14:44 GMT
On Tue, Jun 14, 2011 at 01:39:20PM -0500, Richard Frovarp wrote:
>> Looks like this is the inaugural ASF release for Droids, right?
>
> Thank you for looking at this. Yes, it will be.

w00t! 

> Yes, the page needs to be updated. Ross has provided us with a link to  
> the page on how to update that information. I personally haven't had  
> time to do it. I think I'm on the PPMC, but for the Incubator, I'm not  
> quite sure the distinction between a PPMC member and a committer.

The roles are just as distinct as they are between a Committer and a PMC
member for a top-level project, and there are separate voting procedures.
Some projects add both roles at once:

    http://incubator.apache.org/guides/ppmc.html#Voting+in+a+new+committer
    http://incubator.apache.org/guides/ppmc.html#Voting+in+a+new+PPMC+member

    For projects which wish to have all committers also be PPMC members, the
    "Voting in a new PPMC member" guide below should then be followed, noting
    that if desired it is possible to run a joint committership and PPMC vote,
    providing that the guidance for both is followed.

There should be archived VOTE threads on the droids-private list, which were
cc'd to private@incubator.a.o.  Hopefully they were for PPMC membership.  If
not, there will be some cleanup work to do.

>> ... Thorsten is not on the IPMC right now, though as an ASF Member he can
>> simply request to join.  Once that happens, you'll have 1 IPMC vote.
>
> But he is. Several months ago the board acked his request, but it would  
> appear that the IPCM membership roster hasn't been updated.

OK, great!  That's resolved.

> Ross participated in a previous vote that didn't pass as we found things  
> we need to clean up. It would seem he didn't have the time to  
> participate this time.

OK, that's reassuring. :)

(Looks like OOo is already starting to impact our volunteer resources.)

FYI, at this point I still plan to gate my vote on a +1 vote from a Droids
Mentor.  IMO, it would be less than ideal to have an inaugural release
approved by one interested party (Thorsten) augmented by freelancers, even if
one or more Mentors has expressed some measure of support in the past.

>> In principle, I'd like to freelance and contribute some oversight towards your
>> release by performing a surface review and voting.  I can check license
>> headers, sigs and sums, etc, and help with an audit of LICENSE and NOTICE,
>> especially if we can work together to produce an authoritative list of the
>> project's dependencies.  Unfortunately, my Java expertise is almost all
>> theoretical, so code review will be limited to fumbling around until I figure
>> out how to run the test suite and verify that it passes.
>
> I can put together a list. Maven should give it to me easily and I can  
> post. 

That would be most helpful.

I intend to rely on this list as authoritative, as assessing a Java code base
for dependencies is outside my area of expertise.

> I've gone through it quite carefully and everything I can see indicates that
> we are good.  I've been doing some of this as PMC Chair for Apache Lenya, so
> I do have some experience with it.

Excellent.  Was your work documented anywhere?  Ideally, there would be a JIRA
issue I can read over explaining why each dependency with a non-category-A
license is OK.

    http://www.apache.org/legal/resolved.html

> Further help and guidance of course is always welcome.

You are gracious.  I'll defer to others on guidance; I see my role as more
that of a QC engineer.

And to start off my QC, I'll note that there are some oddities in the top
level directory of the archive.  Here's the file list:

    DEPENDENCIES
    LICENSE
    LICENSE.txt
    NOTICE
    NOTICE.txt
    README.TXT
    droids-core
    droids-norobots
    droids-solr
    droids-spring
    droids-tika
    droids-wicket
    pom.xml

The LICENSE and LICENSE.txt files are essentially duplicates of each other,
having only whitespace differences.  However, the NOTICE and NOTICE.txt files
are quite distinct (diff below my sig).  I think this is a blocker.

I'm not sure what the DEPENDENCIES file is supposed to tell us, but it contains
minimal information.  Presumably it's some Maven thing I just don't grok.

Lastly, I think it's worth commenting on the contents of README.TXT, which
starts off like so:

                        A p a c h e    D r o i d s 
                        --------------------------

               by Thorsten Scherler <thorsten at apache.org>

That credit is obviously inaccurate and seems quite unusual for an Apache
project.  I know that other projects have gone out of their way to delete all
@author tags.  Perhaps Droids might consider doing likewise.

I also intend to run a RAT report, and to pore over LICENSE and NOTICE more
thoroughly, but I'm out of time for today and wanted to get you this feedback
sooner rather than later.

Best,

Marvin Humphrey


marvin@smokey:~/Desktop/droids/droids-0.1-incubating $ diff -u NOTICE NOTICE.txt 
--- NOTICE  2011-05-25 21:36:50.000000000 -0700
+++ NOTICE.txt  2011-05-25 21:35:20.000000000 -0700
@@ -1,8 +1,58 @@
-
-Droids
-Copyright 2007-2011 The Apache Software Foundation
+Apache Droids
+Copyright 2008-2011 The Apache Software Foundation.
 
 This product includes software developed at
 The Apache Software Foundation (http://www.apache.org/).
 
+See also the file LICENSE.txt and README.txt
+
+------------------------------------------------------------------------
+The purpose of this NOTICE.txt file is to contain notices that are
+required by the copyright owner and their license. Some of the
+accompanying products have an attribution requirement, so see below.
+Other accompanying products do not require attribution, so are not listed.
+
+------------------------------------------------------------------------
+
+==============================================================
+ CGLib
+==============================================================
+ This product includes software developed by the CGLib Project
+ (http://cglib.sourceforge.net). Licensed under the 
+ Apache Software License
+ 
+ 
+==============================================================
+ Jetty Web Container 
+ Copyright 1995-2006 Mort Bay Consulting Pty Ltd
+==============================================================
+
+This product includes some software developed at The Apache Software 
+Foundation (http://www.apache.org/).
+
+The javax.servlet package used by Jetty is copyright 
+Sun Microsystems, Inc and Apache Software Foundation. It is 
+distributed under the Common Development and Distribution License.
+You can obtain a copy of the license at 
+https://glassfish.dev.java.net/public/CDDLv1.0.html.
+
+The UnixCrypt.java code ~Implements the one way cryptography used by
+Unix systems for simple password protection.  Copyright 1996 Aki Yoshida,
+modified April 2001  by Iris Van den Broeke, Daniel Deville.
+
+The default JSP implementation is provided by the Glassfish JSP engine
+from project Glassfish http://glassfish.dev.java.net.  Copyright 2005
+Sun Microsystems, Inc. and portions Copyright Apache Software Foundation.
+
+Some portions of the code are Copyright:
+  2006 Tim Vernum 
+  1999 Jason Gilbert.
+
+The jboss integration module contains some LGPL code.
+
+========================================================================
+JUnit
+========================================================================
+This product includes software developed by JUnit (http://www.junit.org).
+Licensed under the Common Public License v 1.0
 



---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message