incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Rheinheimer <r...@apache.org>
Subject Re: [VOTE] Release Wink 1.1 (incubating)
Date Tue, 11 May 2010 22:05:07 GMT
Sebb,

Sorry, I was incomplete in my explanation.  Regarding the services files,
the JAX-RS API jar is reading the first line in these files.  I just
confirmed it again in my build; if I add a # comment as the first line in
wink-common/src/main/
resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate, the JAX-RS API
reads that first line, and we see errors everywhere.  Of course, we have no
ability to quickly fix the JAX-RS API code.  Your thoughts?

Also, I went back and fixed the site again per your suggestions.  I've not
done the 1.1 parts yet since we don't yet have a release, of course.

I don't have a strong objection to changing the Apache license goal to only
run during -PCIBuild.  Not sure why this is an issue exactly though.  Is it
just to keep the output cleaner for developers?  Does it pollute Hudson
build output?  I just don't know.

Thanks again.
mike


On Tue, May 11, 2010 at 4:31 PM, sebb <sebbaz@gmail.com> wrote:

> On 11/05/2010, Mike Rheinheimer <rott@apache.org> wrote:
> > Thanks Sebb for your review,
> >
> >  I'll try to address each of your concerns:
> >
> >  1)  AL headers are missing from...
> >
> >  These files list implementation classes like other standard
> >  META-INF/services/* files.  We may be able to accommodate and re-write
> code
> >  that reads these files in the next release but I don't believe these
> should
> >  be release blockers.
>
> I assumed these were standard services files which do allow comments.
> See for example:
>
>
> http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#Provider%20Configuration%20File
>
> which describes the service file format.
>
> >  2)  The Wink download page does not have a link to the KEYS file; this
> >
> > should be fixed before any release please.
> >
> >
> > I've added a link for the KEYS file.  Site will be updated as soon as I
> have
> >  proper permissions on people.apache.org.
>
> Thanks, seen it via people proxy.
>
> The link is to an SVN tag, which works, however is not usual.
>
> There's a copy of KEYS in
>
> http://www.apache.org/dist/incubator/wink/
>
> which is a more usual location for links to refer to, and is closer to
> the hashes/sigs.
>
> BTW, the amended download page has two copies of the "Instructions"
> and "SVN" URLs under the 1.0 release table.
>
> Also, just noticed that the 0.1 release location is still using
> www.apache.org.
>
> Archived releases should be referenced from archive.apache.org, e.g.:
>
> http://archive.apache.org/dist/incubator/wink/0.1-incubating/
>
> Once the 1.0 release has been available for a week or so, any previous
> releases should be deleted from www.apache.org/dist. They will remain
> on archive.a.o forever.
>
> >  3)  Also, the SNAPSHOT downloads should not be listed...
> >
> >  Also fixed.  Site will be updated as soon as I have proper permissions
> on
> >  people.apache.org.
> >
> >  4)  It would be useful to include details of how to use sigs and hashes
> to
> >  check downloads.
> >
> >  Added a link from the downloads page to the Apache instructions.  Site
> will
> >  be updated as soon as I have proper permissions on people.apache.org.
> >
> >  5)  This reports a lot of warnings from the license:check goal...
> >
> >  My personal preference is that this goal remains.  It has served us
> well.
> >  :)
>
> But does it need to be run for every install?
>
> Surely you only need it for the -PCIBuild installs.
>
> >  6)  Also, I got a test error:...
> >
> >  This test has been running consistently in Hudson since its creation,
> and
> >  has been successful for individual developers as well.  I'll be glad to
> open
> >  a Jira and review the problem, but I don't think this is a release
> blocker.
> >
> >  Thanks again,
> >  mike
> >
> >
> >
> >
> >
> >  On Tue, May 11, 2010 at 2:08 PM, sebb <sebbaz@gmail.com> wrote:
> >
> >  > Just tried building the source archive using mvn install.
> >  >
> >  > This reports a lot of warnings from the license:check goal.
> >  > Seems unnecessary to include a license check in every build; it should
> >  > probably be run as part of the site generation - if it is run
> >  > automatically at all.
> >  >
> >  > Also, I got a test error:
> >  >
> >  > Failed tests:
> >  >
> >  >
>  testCustomResolverCacheOn(org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest)
> >  >
> >  > junit.framework.AssertionFailedError: expected: 20 > 38
> >  >        at junit.framework.Assert.fail(Assert.java:47)
> >  >        at junit.framework.Assert.assertTrue(Assert.java:20)
> >  >        at
> >  >
> org.apache.wink.server.internal.providers.entity.JAXBCustomContextResolverCacheTest.testCustomResolverCacheOn(JAXBCustomContextResolverCacheTest.java:197)
> >  >
> >  >
> >  > On 11/05/2010, sebb <sebbaz@gmail.com> wrote:
> >  > > On 11/05/2010, Mike Rheinheimer <rott@apache.org> wrote:
> >  > >  > IPMCers,
> >  > >  >
> >  > >  >  Wink 1.1 release voting has completed successfully on the
> wink-dev
> >  > list.
> >  > >  >  I'm now calling the IPMC vote to release Wink 1.1 (incubating)
> per
> >  > the
> >  > >  >  process indicated here:
> >  > >  >
> >  >
> http://incubator.apache.org/guides/releasemanagement.html#best-practice-incubator-release-vote
> >  > >  >
> >  > >  >  The Maven staging area is at:
> >  > >  >
> >  > https://repository.apache.org/content/repositories/orgapachewink-007/
> >  > >  >
> >  > >  >  The distributions are in:
> >  > >  >
> >  >
> https://repository.apache.org/content/repositories/orgapachewink-007/org/apache/wink/apache-wink/1.1-incubating/
> >  > >  >
> >  > >  >  This release is tagged at:
> >  > >  >
> >  >
> https://svn.apache.org/repos/asf/incubator/wink/tags/wink-1.1-incubating
> >  > >  >  (revision 941046)
> >  > >  >
> >  > >
> >  > >
> >  > > AL headers are missing from:
> >  > >
> >  > >
> >  >
>  wink-common/src/main/resources/META-INF/services/javax.ws.rs.ext.RuntimeDelegate
> >  > >  wink-examples/ext/WebDAV/src/main/webapp/WEB-INF/application-dav
> >  > >
> >  > >  The Wink download page does not have a link to the KEYS file; this
> >  > >  should be fixed before any release please.
> >  > >
> >  > >  Also, the SNAPSHOT downloads should not be listed on the public
> >  > >  download page. Only approved releases should be made generally
> >  > >  available.
> >  > >
> >  > >  It would be useful to include details of how to use sigs and hashes
> to
> >  > >  check downloads.
> >  > >
> >  > >
> >  > >  >  The vote will be open here for at least 72 hours (ending Friday,
> May
> >  > 14,
> >  > >  >  10:45am US CST).  Please indicate your vote:
> >  > >  >
> >  > >  >  [ ] +1 to release Wink 1.1 incubating
> >  > >  >  [ ] +0
> >  > >  >  [ ] -1 NOT to release Wink 1.1 incubating (and why)
> >  > >  >
> >  > >  >  Thanks!
> >  > >  >
> >  > >  > mike
> >  > >  >
> >  > >
> >  >
> >
> > > ---------------------------------------------------------------------
> >  > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >  > For additional commands, e-mail: general-help@incubator.apache.org
> >  >
> >  >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message