Return-Path: Delivered-To: apmail-incubator-general-archive@www.apache.org Received: (qmail 7195 invoked from network); 12 Nov 2009 17:05:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Nov 2009 17:05:24 -0000 Received: (qmail 32397 invoked by uid 500); 12 Nov 2009 17:05:23 -0000 Delivered-To: apmail-incubator-general-archive@incubator.apache.org Received: (qmail 32202 invoked by uid 500); 12 Nov 2009 17:05:23 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 32192 invoked by uid 99); 12 Nov 2009 17:05:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2009 17:05:23 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of matthieu.riou@gmail.com designates 209.85.221.191 as permitted sender) Received: from [209.85.221.191] (HELO mail-qy0-f191.google.com) (209.85.221.191) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2009 17:05:13 +0000 Received: by qyk29 with SMTP id 29so1235977qyk.32 for ; Thu, 12 Nov 2009 09:04:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:reply-to:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=6HSzPaFXK0vDy1Mui7SFKPjP+XfTk73sxvwvhecVHFY=; b=B+68mxMO8oysGboLcYInrlqfDxSIiAY7hiZ96GVc/5UGnO65ZCc1ZGrE4nK6pkwwtQ rTQ41wnJmf2hq3/jWUU0tcu6Uv0UaGgJFDwS8y//SSjTAJKcHEeBV3u5XDAovr/5BVKw uwmkJEsnYbQxLfpjeEXOAUeCREZJKgZYcj7Nc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:content-type; b=aNCKvotaYgTWbDOvLNPWLiKIS2HK1uZ6WSmrqYPNhDOhvoq+RrliBWRGIVUkuvwJgm 52ttznegkwS0ARfgpmuEmCUz+VwisQ4PwUUI0vsS0wGBng3Ok6YKFEATQXeIfSOf/dDu JJmdbLhtZOywOMCtx15w2TYHgnjMzZL2jeEHM= MIME-Version: 1.0 Received: by 10.224.50.137 with SMTP id z9mr1774314qaf.83.1258045492831; Thu, 12 Nov 2009 09:04:52 -0800 (PST) Reply-To: matthieu.riou@gmail.com In-Reply-To: <71e1b5740911120855h504bf894o75b949abdcef048b@mail.gmail.com> References: <200911111131.26027.dkulp@apache.org> <71e1b5740911112316o296b441dk6a47e1a2073986a0@mail.gmail.com> <1258042332.13319.42.camel@achilles> <71e1b5740911120824t7d037af5m51133d1ffcd01355@mail.gmail.com> <71e1b5740911120855h504bf894o75b949abdcef048b@mail.gmail.com> Date: Thu, 12 Nov 2009 09:04:52 -0800 Message-ID: Subject: Re: Review-Then-Commit From: Matthieu Riou To: general@incubator.apache.org, antelder@apache.org Content-Type: multipart/alternative; boundary=00c09f88cdedb62ccd04782f8a99 X-Virus-Checked: Checked by ClamAV on apache.org --00c09f88cdedb62ccd04782f8a99 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Nov 12, 2009 at 8:55 AM, ant elder wrote: > On Thu, Nov 12, 2009 at 4:36 PM, Jonathan Ellis wrote: > > > On Thu, Nov 12, 2009 at 10:24 AM, ant elder wrote: > >> So about 40% of the committed code is coming from others and reviewed > >> by others - great - why not make some of those others committers? > > > > It's a long tail sort of thing. > > > > We follow the convention Johan suggested of assigning the Jira issue > > to the author of the change, so e.g. for 05 the contributions look > > like this: > https://issues.apache.org/jira/secure/ConfigureReport.jspa?versionId=12314040&issueStatus=all&selectedProjectId=12310865&reportKey=com.sourcelabs.jira.plugin.report.contributions%3Acontributionreport&Next=Next > > > > That JIRA report shows a range of contributors that many TLPs would be > envious of, and it shows a quite different picture from the commit > history, eg: > > > http://www.svnsearch.org/svnsearch/repos/ASF/search?from=20090801&to=20091231&path=%2Fincubator%2Fcassandra > > Evan and Jonathan are the most active committers but still I can see quite a few: patch by Jaakko Laine and jbellis patch by Scott White; reviewed by Brandon Williams patch by Jaakko Laine; reviewed by jbellis patch by Gary Dusbabek; reviewed by eevans And that's only going as far as 2 days ago. So is the problem only what the commit log looks like if you only look at who committed the patch? Matthieu It would be great to get more of those contributors actually doing the > commits though, maybe modifying the current commit process as is being > suggested in this thread could help get that to happen. > > ...ant > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org > For additional commands, e-mail: general-help@incubator.apache.org > > --00c09f88cdedb62ccd04782f8a99--