Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of hedhman@gmail.com designates
 209.85.218.210 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type;
        b=A84BZ66xPeNSEOVYZId8sFubM7SHEn+1cyVIVELJY3NTEwdGDOnzDHa3h+83fMxUXl
         GT8Ae72tkj/tWzgUFM9cnUwWJnfMfRNyIg7yt2MGHa45SJgRP/+XdZEP86VMQMWtxVRG
         anGt8aqOLjREr/kucgzsDc5OJ60DakEUJgSHM=
MIME-Version: 1.0
Sender: hedhman@gmail.com
In-Reply-To: <4AFDD00A.4030803@apache.org>
References: <fbdc6a970911110809o6400dd6fwf4a2f30d8b601e06@mail.gmail.com>
	 <6cca3db30911111916o69a9557ar7ad4b3eea2f0d9de@mail.gmail.com>
	 <a4265f2a0911121446j73f95585wcc2fc9b73bf847c9@mail.gmail.com>
	 <4AFDD00A.4030803@apache.org>
Date: Sat, 14 Nov 2009 14:07:18 +0800
Message-ID: <caf30e2a0911132207w496755e1k75f4a14c671ff140@mail.gmail.com>
Subject: Re: Review-Then-Commit
From: Niclas Hedhman <niclas@hedhman.org>
To: general@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1

On Sat, Nov 14, 2009 at 5:30 AM, Doug Cutting <cutting@apache.org> wrote:
> Aidan Skinner wrote:
>>
>> I'd flip this around and look at it from the PoV of a
>> not-yet-committer. RTC means everybody goes through basically the same
>> process - (raise jira), hack, submit patch, patch gets reviewed, patch
>> gets committed regardless of whether they have a commit bit or not.
>
> +1 With RTC as I've practiced it, becoming a committer doesn't so much give
> a privilege as a duty: committers are expected to review and commit patches
> promptly.

I am curious (never worked in a RTC environment);

Does that mean that people turn down offers of commit rights? Does it
mean that less commit rights are offered? Does it mean that commit
rights are offered to those that do reviews even if they don't write
much code?

I mean, if I can see only downsides, then why should I bother? Perhaps
bragging rights to friends are enough for first-timers, but hardly to
people that have been around the block a few times...


Cheers
-- 
Niclas Hedhman, Software Developer
http://www.qi4j.org - New Energy for Java

I  live here; http://tinyurl.com/2qq9er
I  work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org