Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of elecharny@gmail.com designates
 209.85.218.210 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=sender:message-id:date:from:user-agent:mime-version:to:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        b=OZ7OTOogleAc4yj7aykGOEVDsIKABXwcSbhaFZs+L136DH6FgIzK1nnVnlG3MvL61z
         pe1rDtjclApXCo5ThzoGu7Y3rhogunqhqmlBGgT5aHEy8MTVEn81tqVXIXj0gLip0+ip
         Vzjpr8luSw6fs6WBNFsOr8x09KoPn5wIL0ClA=
Sender: Emmanuel Lecharny <elecharny@gmail.com>
Message-ID: <4AFBDBEE.7060406@nextury.com>
Date: Thu, 12 Nov 2009 10:57:02 +0100
From: Emmanuel Lecharny <elecharny@apache.org>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: general@incubator.apache.org
Subject: Re: Review-Then-Commit
References: <fbdc6a970911110809o6400dd6fwf4a2f30d8b601e06@mail.gmail.com>
 <6cca3db30911111916o69a9557ar7ad4b3eea2f0d9de@mail.gmail.com>
 <AC40124A-43EF-4BDF-B846-881CAF8E12E7@tfd.co.uk> <4AFBD840.1060208@wyona.com>
In-Reply-To: <4AFBD840.1060208@wyona.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

Michael Wechner wrote:
> Ian Boston schrieb:
>>
>>
>> not least because committed mistakes demand fixing by the committer 
>> and then anyone who can fix the bug. The only downside is that 
>> occasionally trunk wont build/run and if trunk is close to production 
>> that probably matters.
>
> I think another downside is, that (maybe depending on the community) 
> in reality a proper review often doesn't happen in the case
> of CTR and in the case of performance/scalability this can be very 
> bad, because the actual problems are often detected
> at a very late stage and then it can be very hard to solve these 
> issues, because the code has already advanced too far.
>
> I see the postive sides of CTR re community and progress,  but I think 
> it requires some additional rules, guidelines
> in order to make it work.
As a matter of fact, at Directory, we are using CTR since the beginning, 
and we have had to define those rules. It's pretty easy :
- if it does not compile locally, don't commit
- when you commit, always try to do it in a way a simple revert restore 
the previous state
- when doing some heavy refactoring, do it in a branch
- add some integration tests early in the process
- for new committers, check their commits until they are trustable
- define some code rules (syntax, comments, etc) followed by everyone.

That's pretty much it, and it work quite well considering the project 
size (325 000 slocs as of today...)

-- 
--
cordialement, regards,
Emmanuel L�charny
www.iktek.com
directory.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org