incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthieu Riou <matthieu.r...@gmail.com>
Subject Re: Review-Then-Commit
Date Thu, 12 Nov 2009 17:04:52 GMT
On Thu, Nov 12, 2009 at 8:55 AM, ant elder <antelder@apache.org> wrote:

> On Thu, Nov 12, 2009 at 4:36 PM, Jonathan Ellis <jbellis@gmail.com> wrote:
>
> > On Thu, Nov 12, 2009 at 10:24 AM, ant elder <ant.elder@gmail.com> wrote:
> >> So about 40% of the committed code is coming from others and reviewed
> >> by others - great - why not make some of those others committers?
> >
> > It's a long tail sort of thing.
> >
> > We follow the convention Johan suggested of assigning the Jira issue
> > to the author of the change, so e.g. for 05 the contributions look
> > like this:
> https://issues.apache.org/jira/secure/ConfigureReport.jspa?versionId=12314040&issueStatus=all&selectedProjectId=12310865&reportKey=com.sourcelabs.jira.plugin.report.contributions%3Acontributionreport&Next=Next
> >
>
> That JIRA report shows a range of contributors that many TLPs would be
> envious of, and it shows a quite different picture from the commit
> history, eg:
>
>
> http://www.svnsearch.org/svnsearch/repos/ASF/search?from=20090801&to=20091231&path=%2Fincubator%2Fcassandra
>
>
Evan and Jonathan are the most active committers but still I can see quite a
few:

patch by Jaakko Laine and jbellis
patch by Scott White; reviewed by Brandon Williams
patch by Jaakko Laine; reviewed by jbellis
patch by Gary Dusbabek; reviewed by eevans

And that's only going as far as 2 days ago. So is the problem only what the
commit log looks like if you only look at who committed the patch?

Matthieu

It would be great to get more of those contributors actually doing the
> commits though, maybe modifying the current commit process as is being
> suggested in this thread could help get that to happen.
>
>   ...ant
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message