incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niclas Hedhman <nic...@hedhman.org>
Subject Re: Review-Then-Commit
Date Sat, 14 Nov 2009 06:07:18 GMT
On Sat, Nov 14, 2009 at 5:30 AM, Doug Cutting <cutting@apache.org> wrote:
> Aidan Skinner wrote:
>>
>> I'd flip this around and look at it from the PoV of a
>> not-yet-committer. RTC means everybody goes through basically the same
>> process - (raise jira), hack, submit patch, patch gets reviewed, patch
>> gets committed regardless of whether they have a commit bit or not.
>
> +1 With RTC as I've practiced it, becoming a committer doesn't so much give
> a privilege as a duty: committers are expected to review and commit patches
> promptly.

I am curious (never worked in a RTC environment);

Does that mean that people turn down offers of commit rights? Does it
mean that less commit rights are offered? Does it mean that commit
rights are offered to those that do reviews even if they don't write
much code?

I mean, if I can see only downsides, then why should I bother? Perhaps
bragging rights to friends are enough for first-timers, but hardly to
people that have been around the block a few times...


Cheers
-- 
Niclas Hedhman, Software Developer
http://www.qi4j.org - New Energy for Java

I  live here; http://tinyurl.com/2qq9er
I  work here; http://tinyurl.com/2ymelc
I relax here; http://tinyurl.com/2cgsug

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message