incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doug Cutting <>
Subject Re: Review-Then-Commit
Date Mon, 16 Nov 2009 22:38:41 GMT
Niclas Hedhman wrote:
> I am curious (never worked in a RTC environment);
> Does that mean that people turn down offers of commit rights? Does it
> mean that less commit rights are offered? Does it mean that commit
> rights are offered to those that do reviews even if they don't write
> much code?

No to all, in my experience.

Code reviews generally improve code quality.  Every change should be 
reviewed, regardless of whether RTC or CTR are used.  RTC simply 
formalizes the review step of the process.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message