Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Received-SPF: pass (nike.apache.org: local policy)
From: "Snitkovsky, Martin" <martin.snitkovsky@hp.com>
To: "sebbaz@gmail.com" <sebbaz@gmail.com>, "general@incubator.apache.org"
	<general@incubator.apache.org>
CC: "wink-dev@incubator.apache.org" <wink-dev@incubator.apache.org>
Date: Sun, 9 Aug 2009 08:02:59 +0000
Subject: RE: [VOTE] Releasing Wink 0.1
Thread-Topic: [VOTE] Releasing Wink 0.1
Thread-Index: AcoWqw2r9k/JTD/2SPCmlHYuealcZACEBHdA
Message-ID: 
 <2C60AA1B234AC84D8486DC6BA56275FC508A5BAF36@GVW1163EXB.americas.hpqcorp.net>
References: 
 <2C60AA1B234AC84D8486DC6BA56275FC508A3CA7E7@GVW1163EXB.americas.hpqcorp.net>
	 <25aac9fc0908060737j1e3aaf99ye2f97c1fe5b7d46f@mail.gmail.com>
 <25aac9fc0908060831x21331f3ch8e1136bf304149f2@mail.gmail.com>
In-Reply-To: <25aac9fc0908060831x21331f3ch8e1136bf304149f2@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Hi Sebb,=20

1. As you noticed, sources/javadoc jars are missing default implementation =
and specification entries.=20
   As good Apache citizens, we use apache-6.pom for all common plugin confi=
guration.
   For maven-source-plugin, apache apache-6.pom uses old version 2.0.4 that=
 has this issue http://jira.codehaus.org/browse/MSOURCES-42=20
   For maven-javadoc-plugin, apache apache-6.pom does not define default im=
plementation and specification entries.=20
So I went ahead, and made required changes in our main pom.=20

*Question* - how do we fix these issues in next version of apache-[X].pom ?=
=20

2. You suggested to add a compiler source and target settings to manifest (=
these are proprietary headers, right?). Correct me if I am wrong, but we al=
ready have "Build-Jdk" header that provides same information.

3. You mentioned that NOTICE and LICENSE files are missing in individual ja=
rs - can you be more specific? =20


Thanks for your comments.

Martin


-----Original Message-----
From: sebb [mailto:sebbaz@gmail.com]=20
Sent: Thursday, August 06, 2009 6:32 PM
To: general@incubator.apache.org
Cc: wink-dev@incubator.apache.org
Subject: Re: [VOTE] Releasing Wink 0.1

On 06/08/2009, sebb <sebbaz@gmail.com> wrote:
> On 06/08/2009, Snitkovsky, Martin <martin.snitkovsky@hp.com> wrote:
>  > The Wink community has started the voting to release Wink 0.1.
>  >  The voting mail thread can be viewed at http://mail-archives.apache.o=
rg/mod_mbox/incubator-wink-dev/200908.mbox/<2C60AA1B234AC84D8486DC6BA56275F=
C508A3CA379@GVW1163EXB.americas.hpqcorp.net>
>  >
>  >  We are sending this e-mail as a heads up so we can get additional fee=
dback on the artifacts from the community.
>  >
>  >  The Maven staging area is at:
>  >  https://repository.apache.org/content/repositories/wink-staging-014/
>  >
>  >  The distributions are in:
>  >  https://repository.apache.org/content/repositories/wink-staging-014/o=
rg/apache/wink/apache-wink/0.1-incubating/
>
>
> No point in having .asc.md5 and .asc.sha1 files; these should be
>  deleted before release.
>
>  The signing key does not seem to have been uploaded to any pgp servers.
>  [Key id 0x5E67E108]
>
>  Also, could not find the KEYS file.
>
>  It's not possible to check the sigs.
>
>  The hashes are OK.
>

Some of the jars have manifests which include the following:

Specification-Title: Wink WebDav
Specification-Version: 0.1-incubating
Specification-Vendor: The Apache Software Foundation
Implementation-Title: Wink WebDav
Implementation-Version: 0.1-incubating
Implementation-Vendor-Id: org.apache.wink
Implementation-Vendor: The Apache Software Foundation

This is good as it helps to identify the jar in isolation.
However, not all of the jars have this information.
It would also be good to include the compiler source and target settings.

I'd like to see the NOTICE and LICENSE files also in the individual
jars (in the META-INF directory). At present they only seem to be in
the source jars, which don't have the full manifest info as above.

I got one test failure:

Failed tests:
  testLockingExample(org.apache.wink.example.locking.LockingTest)

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0

I'll raise a JIRA and attach the Surefire output files.

>  >  This release is tagged at:
>  >  https://svn.apache.org/repos/asf/incubator/wink/tags/wink-0.1-incubat=
ing/
>
>
> The LICENSE and NOTICE files need to be in the top-level directory.
>
>  I had problems checking out the SVN tree because some of the path/file
>  names are extremely long (up to 198 characters), for example:
>
>  wink-integration-test/wink-server-integration-test/wink-jaxrs-test-provi=
ders/src/test/java/org/apache/wink/jaxrs/test/providers/exceptionmappers/nu=
llconditions/JAXRSExceptionsNullConditionsTest.java
>
>  In the end I had to check out the tree into a top-level directory with
>  a short name.
>  This is on Win/XP.
>
>  I also had problems with the archives for the same reason.
>
>  I think this is going to cause problems for other users too.
>
>  There are quite a lot of files in SVN that are not in the source
>  archive, for example:
>
>  release_notes.txt
>  Apache_Wink_User_Guide.docx/pdf
>
>  src/assembly/dist.xml
>  etc.
>
>  Missing AL header:
>  wink-integration-test/wink-server-integration-test/wink-jaxrs-optional-p=
roviders/pom.xml
>
>  As a separate issue, there are a lot of missing SVN properties (mainly
>  eol-type:native).
>  I'll file a bug report for that.
>
>
>  >  Thanks,
>  >  Martin
>  >
>  >  ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>  >  For additional commands, e-mail: general-help@incubator.apache.org
>  >
>  >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org