incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francis De Brabandere <franci...@gmail.com>
Subject Re: [VOTE] Release Empire-db 2.0.5
Date Fri, 21 Aug 2009 12:19:00 GMT
So sebb, what tool are you using there to come up with all those issues ;-)

On the distribution file(s). Is this standard practice described
somewhere. Can you suggest a model project that is using maven? If we
have binaries separated should we also provide libraries in that zip?

Since we moved to maven this is kind of a first release all over
again... We're going to fix all issues and come back with a proper
release later this month.

Thanks for the thorough review.

Francis

On Fri, Aug 21, 2009 at 2:05 PM, sebb<sebbaz@gmail.com> wrote:
> On 21/08/2009, Martijn Dashorst <martijn.dashorst@gmail.com> wrote:
>> On Fri, Aug 21, 2009 at 1:52 PM, sebb<sebbaz@gmail.com> wrote:
>>  > There is only a combined source/binary archive, which is not standard practise.
>>  > All other projects release a source archive; almost all also release a
>>  > separate binary archive.
>>
>>
>> FWIW, Apache Wicket has released combined binary/source archives since
>>  its inception. Not something that needs changing.
>>
>>
>>  > The archive does not have a DISCLAIMER file - yes, the disclaimer text
>>  > is in README, but the general practise is for a separate file.
>>
>>
>> DISCLAIMER should be next to LICENSE, NOTICE and README. Remember to
>>  remove upon graduation :-)
>>
>>
>>  > The NOTICE file is incorrect. The date is 2008, and the second
>>  > paragraph must be:
>>  >
>>  > This product includes software developed at
>>  > The Apache Software Foundation (http://www.apache.org/).
>>  >
>>  > i.e. switch the 2nd and 3rd paragraphs
>>
>>
>> Should be fixed.
>>
>>
>>  > Minor points:
>>  >
>>  > It would be useful to include compiler source and target versions as
>>  > headers in the jar manifests (the manifests are otherwise good)
>>
>>
>> Shouldn't maven do this already? [1]
>
> The headers referred to in [1] are present, I was referring to headers such as:
>
> X-Compile-Source-JDK: 1.5
> X-Compile-Target-JDK: 1.5
>
> These need to be added manually. Not essential, but can be very useful.
>
>>  Martijn
>>
>>  [1] http://maven.apache.org/shared/maven-archiver/examples/manifest.html
>>
>>  ---------------------------------------------------------------------
>>  To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>  For additional commands, e-mail: general-help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>



-- 
http://www.somatik.be
Microsoft gives you windows, Linux gives you the whole house.

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message