incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Help reviewing PhotArk podling release
Date Sat, 22 Aug 2009 09:41:54 GMT
On 22/08/2009, Luciano Resende <luckbr1975@gmail.com> wrote:
> On Thu, Aug 20, 2009 at 6:16 PM, sebb<sebbaz@gmail.com> wrote:
>  > Sigs and hashes OK; tgz and zip agree with each other.
>  >
>  > However, the source archive does not agree with the SVN tag - the
>  > versions are different in various pom.xml files.
>
>
> Can you give me one example ? The verious pom.xml should have version
>  id as <version>M1-incubating</version>.
>

SVN: assets/pom.xml

        <dependency>
            <groupId>org.apache.tuscany.sca</groupId>
            <artifactId>tuscany-sca-api-extension</artifactId>
            <version>1.5</version>
            <scope>runtime</scope>
        </dependency>

Archive: assets/pom.xml

        <dependency>
            <groupId>org.apache.tuscany.sca</groupId>
            <artifactId>tuscany-sca-api-extension</artifactId>
            <version>1.4</version>
            <scope>runtime</scope>
        </dependency>

Similarly for other dependencies and for other POMs.

>  >Also there is no DISCLAIMER in the source archive.
>  >
>
> Fixed. Would this require a new RC ?

Yes, and new SVN tag.

>
>  > The distribution/src/main/release/bin/LICENSE file is also different
>  > between SVN and the source archive. But I would not expect to find a
>  > LICENSE file there anyway.
>
>
> The distribution/src/main/release/bin/LICENSE is used to generate the
>  binary distribution, while the LICENSE in the root of the svn is the
>  one used for the source distribution. I'm not sure what do you mean by
>  "But I would not expect to find a LICENSE file there anyway.", as my
>  understanding is that the the source release would have a Apache
>  License there, and any other third party licenses appropriate for the
>  source distribution.

AIUI, the normal place for Maven resources such as this is

src/main/resources

Also it's different from the version in SVN - the versions of tuscany
jars have changed.

>
>  >
>  > I'm not sure why there are additional copies of the NOTICE, LICENSE
>  > etc files in the subdirectories; there should only be copies in the
>  > top-level directory.
>
>
> Similar to above, the copies in the subdirectory are used in the
>  binary distribution.

But there is only a single binary distribution, so surely there should
be at most one common additional LICENSE file? There's one in each
module.

>
>  >
>  > There's no DISCLAIMER in the binary archive.
>  >
>
>
> Fixed
>
>
>  > Minor problems:
>  >
>  > Builds OK using M2/Java 1.5, but there don't appear to be any tests run.
>  >
>  >
>  > README and INSTALL mention April 2009 release.
>  >
>  > The INSTALL file does not really explain how to install anything.
>  >
>  > The POM file needs to specify the encoding to avoid warnings such as
>  > the following:
>  >
>  > [WARNING] File encoding has not been set, using platform encoding
>  > Cp1252, i.e. build is platform dependent!
>  > [WARNING] Using platform encoding (Cp1252 actually) to copy filtered
>  > resources, i.e. build is platform dependent!
>  >
>
>
> What is needed here ? I checked all the pom.xml and they all seem to
>  have the necessary UTF-8 encoding
>  <?xml version="1.0" encoding="UTF-8"?>

You need to set the property for the Maven Resources Plugin:

    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

Might as well do the same for reports:

    <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

>  Note that, looking on the pom.xml from a browser, the encode
>  information is not showed, but a view source or looking directly into
>  the code does show the proper encoding there.
>
>  If you have a specific pom.xml that has this info missing, please let me know.

Set it in the parent pom.

>
>  > Not a release blocker, but worth fixing in SVN trunk:
>  >
>  > svn ps svn:eol-style native DISCLAIMER
>  > svn ps svn:eol-style native assets/DISCLAIMER
>  > svn ps svn:eol-style native assets/LICENSE
>  > svn ps svn:eol-style native assets/NOTICE
>  > svn ps svn:eol-style native photark/DISCLAIMER
>  > svn ps svn:eol-style native photark/LICENSE
>  > svn ps svn:eol-style native photark/NOTICE
>  > svn ps svn:eol-style native photark-webapp/DISCLAIMER
>  > svn ps svn:eol-style native photark-webapp/LICENSE
>  > svn ps svn:eol-style native photark-webapp/NOTICE
>  >
>  > svn pd svn:executable photark/src/main/resources/index.gif
>  > svn pd svn:executable photark/src/main/resources/index_on.gif
>  > svn pd svn:executable photark/src/main/resources/next.gif
>  > svn pd svn:executable photark/src/main/resources/next_disabled.gif
>  > svn pd svn:executable photark/src/main/resources/next_on.gif
>  > svn pd svn:executable photark/src/main/resources/prev.gif
>  > svn pd svn:executable photark/src/main/resources/prev_disabled.gif
>  > svn pd svn:executable photark/src/main/resources/prev_on.gif
>  > svn pd svn:executable photark/src/main/resources/styles.css
>  > svn pd svn:executable photark-webapp/src/main/webapp/index.gif
>  > svn pd svn:executable photark-webapp/src/main/webapp/index_on.gif
>  > svn pd svn:executable photark-webapp/src/main/webapp/next.gif
>  > svn pd svn:executable photark-webapp/src/main/webapp/next_disabled.gif
>  > svn pd svn:executable photark-webapp/src/main/webapp/next_on.gif
>  > svn pd svn:executable photark-webapp/src/main/webapp/prev.gif
>  > svn pd svn:executable photark-webapp/src/main/webapp/prev_disabled.gif
>  > svn pd svn:executable photark-webapp/src/main/webapp/prev_on.gif
>  > svn pd svn:executable photark-webapp/src/main/webapp/styles.css
>  >
>
>
> Fixed both in trunk and release branch.
>
>
>  >>  > [1] http://www.mail-archive.com/photark-dev@incubator.apache.org/msg00139.html
>
>
>
>  --
>  Luciano Resende
>  http://people.apache.org/~lresende
>  http://lresende.blogspot.com/
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>  For additional commands, e-mail: general-help@incubator.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message