Return-Path: 
 <general-return-22213-apmail-incubator-general-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-general-archive@www.apache.org
Received: (qmail 75555 invoked from network); 4 Jun 2009 20:08:30 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 4 Jun 2009 20:08:29 -0000
Received: (qmail 41226 invoked by uid 500); 4 Jun 2009 20:08:41 -0000
Delivered-To: apmail-incubator-general-archive@incubator.apache.org
Received: (qmail 41044 invoked by uid 500); 4 Jun 2009 20:08:40 -0000
Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:general-help@incubator.apache.org>
List-Unsubscribe: <mailto:general-unsubscribe@incubator.apache.org>
List-Post: <mailto:general@incubator.apache.org>
List-Id: <general.incubator.apache.org>
Reply-To: general@incubator.apache.org
Delivered-To: mailing list general@incubator.apache.org
Received: (qmail 41025 invoked by uid 99); 4 Jun 2009 20:08:40 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2009 20:08:40 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.219.220 as permitted sender)
Received: from [209.85.219.220] (HELO mail-ew0-f220.google.com)
 (209.85.219.220)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jun 2009 20:08:29 +0000
Received: by ewy20 with SMTP id 20so1550832ewy.12
        for <multiple recipients>; Thu, 04 Jun 2009 13:08:09 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:in-reply-to:references
         :date:message-id:subject:from:to:cc:content-type
         :content-transfer-encoding;
        bh=AH6jXx7TdIK1JbbDMP12BP0kuXo2DD/e6IqwonQbvg8=;
        b=AzfnJhx2zfCcBC33TGUM4JgT89g2HeKr/8Qc2TlRKwkWHPe83+fDIEIz9XhhSHn9CZ
         loWJYANS55gTub0RY3Z7TXhBQfvbgrV5dHhYwBMD3bGMy6TWpGW2HUvfJi0BSRCUMS4N
         icFavr7oaWvEOV+sQ1ozvE8oIbx3PejFjDdZs=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=ehTdYNeOvLmVpFnSm4SybHHLjuTsp/4ncCai9oGA14PuWSSURXl6G0I7pLBe+OG7UB
         LJJ+1hLu6mTdYqN1N4+xZkf0+wzQ3XPCSuCG7X6BOcwMGUkhlIQ74ZSEHVDUAOzUXTdj
         icpN04X87W8OiwWdqV32fevTHyHpyAHM2petY=
MIME-Version: 1.0
Received: by 10.216.53.139 with SMTP id g11mr920999wec.25.1244146089369; Thu,
	04 Jun 2009 13:08:09 -0700 (PDT)
In-Reply-To: <b71cdca90906041154m2424bd65m50bf8bdd92cd3b7f@mail.gmail.com>
References: <5B321D64-261E-48FD-887E-C6C221E7E129@tfd.co.uk>
	 <25aac9fc0906040821k345dbbe2o97a2f44bd2bf0b1f@mail.gmail.com>
	 <60D3C6B7-A45A-44EC-BBD0-E0423A4CA030@tfd.co.uk>
	 <b71cdca90906041154m2424bd65m50bf8bdd92cd3b7f@mail.gmail.com>
Date: Thu, 4 Jun 2009 21:08:09 +0100
Message-ID: <25aac9fc0906041308v3abb5f8x2377a4ce181936a8@mail.gmail.com>
Subject: Re: [VOTE] Release Apache Incubator Shindig version 1.0 (RC4)
From: sebb <sebbaz@gmail.com>
To: general@incubator.apache.org
Cc: shindig-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

On 04/06/2009, Paul Lindner <lindner@inuus.com> wrote:
> I don't see these as release blockers...  I'd like to see us get the 1.0
>  release out the door and then immediately work to apply the release process
>  to 1.1 snapshots.  This was a frequent request from multiple people at
>  Google I/O.
>
>  On Thu, Jun 4, 2009 at 10:17 AM, Ian Boston <ieb@tfd.co.uk> wrote:
>
>
>  >
>  > On 4 Jun 2009, at 16:21, sebb wrote:
>  >
>  >  On 04/06/2009, Ian Boston <ieb@tfd.co.uk> wrote:
>  >>
>  >>> Hi,
>  >>>
>  >>> Please review and vote on approving the first release of Apache
>  >>> Shindig version 1.0-incubating.
>  >>> Apache Incubator Shindig is a JavaScript container and implementations
>  >>> of the backend APIs and proxy required for hosting OpenSocial
>  >>> applications.
>  >>>
>  >>> Vote Thread.
>  >>> http://markmail.org/thread/mrk4uwe7mg5e3uho
>  >>>
>  >>>
>  >>>
>  >>> Proposed release:
>  >>>
>  >>> https://repository.apache.org/content/repositories/shindig-staging-002//org/apache/shindig/shindig/1.0-incubating/
>  >>>
>  >>> SVN Tag is
>  >>>
>  >>> http://svn.apache.org/repos/asf/incubator/shindig/tags/shindig-project-1.0-incubating/
>  >>> revision 780648
>  >>>
>  >>>
>  >> There are 3 files in the source archive that are missing from SVN:
>  >>
>  >> java/samples/create.sql
>  >> java/samples/derby.log
>  >> java/samples/drop.sql
>  >>
>  >> It looks like these are not supposed to be in the source archive.
>  >>
>  >
>
> > These are probably not supposed to be in the source archive, they must have
>  > slipped trough during the build process, which does have filters in place to
>  > exclude them, but thats obviously not working. I will file a bug.
>  >

The maven-clean-plugin config lists the file names without any path
info, so will only delete files in the working directory.

>  > They are generated by JPA when it build the tests giving the default
>  > database schema for the samples project.

It would be better if the test files were generated in a directory
which is exclusively used for temporary test items, e.g. a work
directory under target/. There would then be no need to remove the
files later.

> >
>  >
>  >>
>  >> Where do the SQL files originate?
>  >> I could not find how these were created from the files in SVN.
>  >>
>  >> =
>  >>
>  >> The file README.svn has a misleading name; it ought to be called
>  >> README_svn.txt or similar otherwise it won't be easily usable on some
>  >> OSes, e.g. Windows.
>  >>
>  >
>
> > Thank you will fix.
>
> >
>  >
>  >>
>  >> Some missing SVN properties (not a release blocker):
>  >>
>  >> svn ps svn:eol-style native LICENSE
>  >> svn ps svn:eol-style native NOTICE
>  >> svn ps svn:eol-style native features/LICENSE
>  >> svn ps svn:eol-style native features/NOTICE
>  >>
>  >
>  >
>
> > Thank you, will fix in svn.
>  >
>  >
>  > IYO, are any of these release blockers ?
>  >

The source archive is supposed to be derivable from SVN, which is why
I asked where the extra files came from. I suppose this is true here.

It's not ideal to leave test output in the source archive; but it is
probably not a release blocker.

However, if I were the RM, I would create another release candidate.

Your call.

>  > Ian
>
> >
>  >
>  >>
>  >>
>  >>  Vote open for 72 hours.
>  >>>
>  >>> [ ] +1
>  >>> [ ] +0
>  >>> [ ] -1
>  >>>
>  >>> Thanks,
>  >>>
>  >>> Ian
>  >>>
>  >>> ---------------------------------------------------------------------
>  >>> To unsubscribe, e-mail:
>  >>> general-unsubscribe@incubator.apache.org
>  >>> For additional commands, e-mail:
>  >>> general-help@incubator.apache.org
>  >>>
>  >>>
>  >>>
>  >> ---------------------------------------------------------------------
>  >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>  >> For additional commands, e-mail: general-help@incubator.apache.org
>  >>
>  >>
>  >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org