incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Approve the release of Shindig Incubator 1.0
Date Mon, 11 May 2009 23:24:55 GMT
Some NOTICE files start with:
   =========================================================================
   ==  NOTICE file corresponding to the section 4 d of                    ==
   ==  the Apache License, Version 2.0,                                   ==
   ==  in this case for the Apache Shindig distribution.                  ==
   =========================================================================

This is wrong, it should start with the text as described here:

http://www.apache.org/legal/src-headers.html#notice

The top-level NOTICE file (and java/NOTICE) also contains details of
the crypto requirements.

These are supposed to be in a README file, see:

http://www.apache.org/dev/crypto.html#inform

NOTICE mentions opensocial-resources, PHPUnit and Zend, but
LICENSE mentions  PHPUnit, Zend and jsmin.php.

I would expect LICENSE to include a mention of opensocial-resources
NOTICE should probably have a mention of jsmin.php

Release archives
----------------
There is no need for .asc.md5 and .asc.sha1 hashes; delete them before
deployment

Binary archives
===============
The war file contains lots of 3rd party libraries.
None of these are mentioned in the NOTICE or LICENCE files.

The N & L files in the java jar files are mostly OK, except
java-features has an incorrect NOTICE file.

Source archives
===============
The tgz and zip files have the same files as each other, and the same
files as SVN.

However, most of the files in the archives are different from the files in SVN.
The source files have additional empty lines at the end, and the PNG
files are unusable.
There's clearly something wrong with the way the files have been added
to the archives.

README.svn has 3 spelling mistakes:

6: supliment => supplement
15,29: it's => its

I've not tried building or testing the release

On 11/05/2009, Ian Boston <ieb@tfd.co.uk> wrote:
>
>  On 11 May 2009, at 18:11, sebb wrote:
>
>
> > On 11/05/2009, Ian Boston <ieb@tfd.co.uk> wrote:
> >
> > > Hi,
> > >
> > > Please review and vote on approving the first release of Apache
> > > Shindig version 1.0-incubating.
> > > Apache Incubator Shindig is a JavaScript container and implementations
> > > of the backend APIs and proxy required for hosting OpenSocial
> > > applications.
> > >
> > > Vote Thread.
> > > http://markmail.org/message/ncwat7aiyfkxq6jf
> > >
> > >
> > > Proposed release:
> > >
> https://repository.apache.org/content/repositories/shindig-staging-013/
> > > Binaries:
> > >
> https://repository.apache.org/content/repositories/shindig-staging-013/
> > > org/apache/shindig/shindig/1.0-incubating/
> > >
> >
> >
> > > SVN Tag:
> > >
> https://svn.apache.org/repos/asf/incubator/shindig/tags/shindig-project-1.0-incubating/
> > >
> >
> > I see you have reused the same SVN tag as in the previous vote.
> >
> > Tags are supposed to be immutable.
> >
> > How are we to know which particular version of the tag really relates
> > to the archives?
> >
> > Please can you provide at least the svn revision of the tag, so people
> > can check that they are voting on the same items.
> >
>
>  From the commit log
>  The Tag was created at revision 772601 on  at Thu May  7 10:45:55 2009 GMT
>
>  verification of the tag version can be found here
> http://svn.apache.org/viewvc/incubator/shindig/tags/shindig-project-1.0-incubating/
>
>  Ian
>
>
>
>
>
> >
> >
> >
> > > Vote open for 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > Thanks,
> > >
> > > Ian
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
> > > general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail:
> > > general-help@incubator.apache.org
> > >
> > >
> > >
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail:
> general-help@incubator.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail:
> general-unsubscribe@incubator.apache.org
>  For additional commands, e-mail:
> general-help@incubator.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message