incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vincent Siveton <vincent.sive...@gmail.com>
Subject Re: Pulling in a branch of JSTemplate into Shindig
Date Mon, 06 Apr 2009 18:27:42 GMT
FYI SHINDIG-1007 provided the patch and was applied.

Vincent

2009/4/6 Evan Gilbert <uidude@google.com>:
> [+general@incubator.apache.org]
>
> This sounds great, want to make this is OK before committing the patch. To
> summarize:
> - Shindig depends on 3 files from open source JsTemplates, (
> http://code.google.com/p/google-jstemplate/, ASL 2.0).
> - We need to make Shindig-specific changes, and want to create a copy in the
> Shindig code base
> - Current plan is to create JIRA issue and check the radio box to grant
> license to ASF
>
> Is this sufficient? Are there more steps we need to take?
>
> Evan
>
> On Thu, Apr 2, 2009 at 10:11 AM, Vincent Siveton
> <vincent.siveton@gmail.com>wrote:
>
>> Sounds like related to SHINDIG-623. Since it is already an ASL code, I
>> think you could just provide a patch in Jira and check the radio box
>> to grant license to ASF.
>> As Ian said, we will improve the README file.
>>
>> Cheers,
>>
>> Vincent
>>
>> 2009/4/2, Ian Boston <ieb@tfd.co.uk>:
>> > I see that comments on have been made to provide A2 licenses where
>> > applicable, and it looks like the rest of the code is A2 licensed.
>> Provided
>> > you as a CLA signitory have recorded permission from the copyright holder
>> > (google I assume) to re-assign the license, and we (Shindig) as a
>> community
>> > are prepared to take on maintenance of the code, then there should be no
>> > problem in pulling this in. There contribution will need to me
>> appropriately
>> > attributed in the NOTICE file.
>> >
>> >  But I am a relative newcomer to Apache, and not a lawyer.
>> >  Ian
>> >
>> >
>> >  BTW, how is the speed of this DOM based lib ?
>> >  I did a project recently where we had to use string parsing and
>> compilation
>> > into native JS, as all the DOM based JS template languages crippled the
>> > browser.
>> >
>> >
>> >
>> >  On 2 Apr 2009, at 15:32, Lev Epshteyn wrote:
>> >
>> >
>> > > Guys, I need advice on how to best go about getting a branch of
>> JSTemplate
>> > > into the Shindig codebase.
>> > >
>> > > JSTemplate is a DOM-based template library currently used by the
>> > client-side
>> > > OpenSocial template implementation. libhttp://
>> > > code.google.com/p/google-jstemplate/
>> > >
>> > > As a result of some spec changes, I have had to modify this library to
>> > > continue working for us - and these changes aren't likely to be
>> integrated
>> > > back into the trunk of JST because they are pretty specific to some
>> > > decisions made by OpenSocial. Therefore, I would like to create a copy
>> > > within the Shindig codebase and modify it as needed.
>> > >
>> > > I had initially (and naively) simply copied the files in as part of a
>> > patch
>> > > (http://codereview.appspot.com/32041/show) but Evan has
>> > suggested that a
>> > > more formal process may be in order. Please let me know what the best
>> way
>> > to
>> > > go about this is.
>> > >
>> >
>> >
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message