incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: UIMA release - lots of missing SVN eol-style property settings
Date Fri, 11 Apr 2008 13:00:21 GMT
On 11/04/2008, Thilo Goetz <twgoetz@gmx.de> wrote:
> sebb wrote:
>
> >
> > The SVN tag
> >
> >
> https://svn.apache.org/repos/asf/incubator/uima/uimaj/tags/uimaj-2.2.2/uimaj-2.2.2-05
> >
> > has lots of missing SVN eol-style settings. See the file
> >
> > uimaj-2.2.2-05.sh
> > in
> > http://people.apache.org/~sebb/SVNfixes/
> >
> > This should probably be applied to trunk as well ...
> >
> >
> ---------------------------------------------------------------------
> > To unsubscribe, e-mail:
> general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail:
> general-help@incubator.apache.org
> >
>
>  Hi Sebb,
>
>  thanks for looking over our release.
>
>  There are a lot of files in your list where not setting
>  the eol-style property is intentional: all our test files.

Which extensions are these?
I can change my script to treat these differently.

>  Setting eol-style:native would make our tests fail on one
>  platform or another as they're usually compared to some
>  expected output, which in turn depends on the exact byte
>  content of the files.
>
>  Unfortunately, there is no (valid) eol-style:none
>  or such that allows us to make this intention explicit.

In which case, the tests may fail to work on OSes with a different
line ending, unless you set the mime-type to binary.

>  For the java code we could set it to native.  We just never
>  felt the need.  Since we need to be careful with our test
>  files, we don't follow the automatic eol-style client setup
>  as recommended.  AFAIK, all UIMA developers use Eclipse
>  for their development, and Eclipse doesn't care about
>  eol style (or not that I noticed anyway).

No it doesn't mind. But SVN does.
If you edit a Java file on Unix and commit to SVN, then someone who
edits it on Mac or Windows and commits to SVN will generate an SVN
diff which shows the whole file has been changed. Makes it very
difficult to see what has actually changed. Likewise for pom.xml etc.

>  I hope you'll agree that it's up to the project to set an
>  eol-style policy.  Our policy is not to set the property
>  unless it's required (e.g., for .sh or .bat files).

Indeed, but see also:

http://www.apache.org/dev/version-control.html#https-svn-config

These conventions are generally used by Java projects, e.g. all of Commons.

>  --Thilo
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail:
> general-unsubscribe@incubator.apache.org
>  For additional commands, e-mail:
> general-help@incubator.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message