incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn Dashorst" <martijn.dasho...@gmail.com>
Subject Re: Re: [PROPOSAL] Thrift
Date Wed, 30 Jan 2008 18:38:52 GMT
Perhaps in the interest of code audit (which needs to be done) and community
building, the code parts of the missing committers should be removed from
the code drop prior to incubation start, and be re-introduced inside the
incubating podling by providing patches through bugzilla?
Martijn

On 1/30/08, David Reiss <dreiss@facebook.com> wrote:
>
> > If there are people who have already proven their *merit* on the
> > project that are not included on the initial list of committers then I
> > think they should be.
>
> >  > In reality, many parts of the Thrift code base are already entirely
> >  > owned by non-Facebook entities. The Cocoa, C#, Perl, and Smalltalk
> >  > implementations for Thrift were all developed entirely outside of
> >  > Facebook, and although Facebook still maintains the trunk, we defer
> >  > review of all these patches to the developers working on those
> >  > libraries.
> >
> > So are these people on the initial list of committers?
>
> Perl was contributed by Jake Luciani, who is a committer, but the
> developers
> of the Cocoa, C#, and Smalltalk bindings are not.  These bindings were
> submitted as a set of a few patches (or in some cases, even a single large
> patch), and added to the tree without extensive review because, quite
> frankly,
> no committers were qualified to review them.  Because, as far as we know,
> the
> original contributors are the only users of these bindings, we've just
> been
> blindly committing any changes they make, so it would make sense for them
> to
> have commit access to their parts of the project.  However, they have not
> been
> active enough in the Thrift community to warrant the trust that comes with
> full commit access.
>
> I would say that the requirements for a language-binding contributor to
> become
> a committer would be some amount of activity on the mailing list and
> either a
> significant review of the binding by a qualified committer or a
> significant
> project using the binding.
>
> --David
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>


-- 
Buy Wicket in Action: http://manning.com/dashorst
Apache Wicket 1.3.0 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.0

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message