incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Please approve Tuscany SCA Java 1.1-incubating release
Date Thu, 24 Jan 2008 16:57:36 GMT
On 24/01/2008, ant elder <ant.elder@gmail.com> wrote:
> I think the NOTICE files in the artifacts that are actually being
> distributed are OK.

Surely the archive bundles are also distributed?

==

There are some discrepancies in the jar files covered by the LICENSE
file - the names mentioned in the LICENSE file don't necessarily
appear in the lib directory (and vice versa)
(LIC=LICENSE, DIR=present in lib directory)

LIC: axis2-adb-codegen-1.3.jar
DIR: axis2-codegen-1.3.jar

LIC: derby-10.1.3.1.jar
DIR: derby-10.1.2.1.jar

LIC: stax-api-1.0.2.jar
DIR: stax-api-1.0-2.jar

The following are mentioned in the LICENSE file, but don't appear to be present:
addressing-1.3.mar
maven-artifact-2.0.2.jar
maven-artifact-manager-2.0.2.jar
maven-error-diagnostics-2.0.2.jar
maven-model-2.0.2.jar
maven-profile-2.0.2.jar
maven-project-2.0.2.jar
maven-repository-metadata-2.0.2.jar
maven-settings-2.0.2.jar
opensaml-1.1.jar
plexus-container-default-1.0-alpha-9.jar
plexus-utils-1.1.jar
rampart-1.3.mar
wagon-file-1.0-alpha-7.jar
wagon-http-lightweight-1.0-alpha-6.jar
wagon-provider-api-1.0-alpha-6.jar

Not sure what "dojotoolkit" mentioned in the LICENSE file refers to.

It would be useful if the LICENSE file used a standard format for the
jar files names, as is done for the ASF jars. Elsewhere in the file,
jars may be listed without the .jar extension and/or without the
version suffix, and sometimes multiple files are listed in a
paragraph.

The lack of a version suffix is potentially serious, as licenses may
change between releases.

> The ${pom.name} is changed by the build process so the
> generated artifact has the proper name, for example, the jar built for
> wsdl2java ends up with a NOTICE file containing "Apache Tuscany SCA
> WSDL2Java Tool", see inside:
> http://people.apache.org/~slaws/tuscany/1.1-RC3/maven/org/apache/tuscany/sca/tuscany-wsdl2java/1.1-incubating/tuscany-wsdl2java-1.1-incubating.jar

That looks OK.
 .
>
> The mortgage-loanapproval is only distributed within the src and bin
> distributions and the NOTICE file in those distributions does include all
> the necessary references so that also looks ok to me.
>
> Including the Derby.log is a mistake, but I don't think its a blocker :)

Agreed.

Though it reveals something about the builder's PC environment, so
they may wish it was not present ;-)

There are several other derby.log files in the source archive.

There's also some 40GB of log-nnn.dat files in the

tuscany-sca-1.1-incubating-src\itest\jms\activemq-data\localhost\journal

directory in the source archive.

Another smaller log file in:

tuscany-sca-1.1-incubating-src\modules\implementation-openjpa\test\log

There are also 3 db.lck files.

Are these really needed for the source archive?

> +1 to release.
>
>    ...ant
>
> On Jan 23, 2008 10:55 PM, sebb <sebbaz@gmail.com> wrote:
>
> > Some of the NOTICE files start with the text:
> >
> > ${pom.name}
> >
> > e.g.
> >
> > tools/wsdl2java
> > and
> > modules/policy
> >
> > This does not seem right.
> >
> > The top-level NOTICE and LICENSE files in demos/mortgage-loanapproval
> > are the standard ASF ones - however NOTICE and LICENSE.txt in the
> > demos/mortgage-loanapproval/src/main/resources/META-INF directory
> > include additional references to Eclipse licenses.
> >
> > Again, I would expect the top-level L&N files for a directory tree to
> > agree with the lower level ones.
> >
> > The file apache-tuscany-sca-1.1-incubating-src.tar.gz contains the
> > file derby.log which perhaps should not be there.
> >
> > On 23/01/2008, Simon Laws <simonslaws@googlemail.com> wrote:
> > > Hi,
> > >
> > > The Tuscany project had a vote on tuscany-dev@ws.apache.org to publish
> > the
> > > Tuscany SCA Java 1.1-incubating release. The vote thread on tuscany-dev
> > has
> > > 7 +1s and an archive can be found at:
> > >
> > > http://www.mail-archive.com/tuscany-dev%40ws.apache.org/msg27321.html
> > >
> > > The release includes new function and bug fixes. You can see a list of
> > > changes at:
> > >
> > >
> > http://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/1.1-RC3/distribution/src/main/release/CHANGES
> > >
> > >
> > > The signed binary and source distributions, the RAT reports, and the
> > Maven
> > > staging repository are listed at the following links.
> > >
> > > SVN Tag:
> > > http://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/1.1-RC3/
> > >
> > > Stage maven repo:
> > > http://people.apache.org/~slaws/tuscany/1.1-RC3/maven/<http://people.apache.org/%7Eslaws/tuscany/1.1-RC3/maven/>
> > > <http://people.apache.org/%7Eslaws/tuscany/1.1-RC3/maven/>
> > >
> > > RAT report:
> > > http://people.apache.org/~slaws/tuscany/1.1-RC3/rat-1.1-RC3.txt<http://people.apache.org/%7Eslaws/tuscany/1.1-RC3/rat-1.1-RC3.txt>
> > <http://people.apache.org/%7Eslaws/tuscany/1.1-RC3/rat-1.1-RC3.txt>
> > >
> > > Binary and source distros (zip/gz/asc/md5) :
> > > http://people.apache.org/~slaws/tuscany/1.1-RC3/<http://people.apache.org/%7Eslaws/tuscany/1.1-RC3/>
> > <http://people.apache.org/%7Eslaws/tuscany/1.1-RC3/>
> > >
> > > Please review and approve the release. This vote will remain open for at
> > > least 72 hours.
> > >
> > > Thanks,
> > >
> > > Simon
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message