Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of robertburrelldonkin@gmail.com
 designates 209.85.132.250 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=VKAw5/iDlELYyQ0kU906FSmtG3kve95CNv7gGaSyteNfD2VpWqmCQHAwn/wdJK0JtVipziqVHZqiCmC51nqPQz64Q+iQ10P3KLjW+dCjMO0VtPNW76zMYGNkeSVdqg5GNf9qAPHv9MUE3yYd17KMAkZdglWG+Gejhva2WVx8b8Q=
Message-ID: <f470f68e0703281422g1bd7a729w4054d3af4119be2c@mail.gmail.com>
Date: Wed, 28 Mar 2007 22:22:04 +0100
From: "robert burrell donkin" <robertburrelldonkin@gmail.com>
To: general@incubator.apache.org
Subject: Re: [VOTE] [Retry] Approve the release of Apache Lucene.Net 2.0 build
 004 incubating
In-Reply-To: <04c001c770f1$6839dbc0$6901a8c0@aroushlt>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <f470f68e0703261419q7de79882g17d3f18efca603fd@mail.gmail.com>
	 <04c001c770f1$6839dbc0$6901a8c0@aroushlt>

On 3/28/07, George Aroush <george@aroush.net> wrote:
> Hi Robert,
>
> Thanks for taking your time and looking at this release.  To answer your
> questions:
>
> The files *.csproj, and *.sln are the Visual Studio.NET project files --
> those are auto generated and thus I can't edit them outside the IDE -- the
> same goes to the few *.cs files that you noticed as well as the few *.xml
> and *.html files that you highlighted.

yeh

IMHO it's pretty naffy that you can't add headers but that's life, i
suppose - or at least m$

> For the file,
> https://svn.apache.org/repos/asf/incubator/lucene.net/trunk/C%23/contrib/Sno
> wball.Net/Test/Analysis/Snowball/TestSnowball.cs where you pointed out the
> use of the old style Apache License, it looks like
> http://www.apache.org/legal/src-headers.html#faq-update-scripts didn't do
> the job well here.  This is an original work -- will this issue prevent a
> release?.

different people have different opinions :-/

(hopefully people will jump in here)

IMHO it's a judgment call. i wouldn't cut a release with any header
issues of this kind but i wouldn't -1 one either.

RAT is good at catching this kind of issue (though it will pick up a
lot of false negatives  for the XML and HTML files)

> Thanks for catching the grammatical error in the README.txt: "An MADN ..."
> I fixed it in the SVN release.
>
> Again, thanks for taking your time and looking at this release candidate.
> Please let me know if I addressed all of your questions and if I get your +1
> or -1 vote.

+0 due to old license

(but i feel a little bad about it)

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org