incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <ni...@apache.org>
Subject RE: [VOTE] Approve the release of Apache Lucene.Net 2.0 build 003 incubating
Date Mon, 05 Mar 2007 12:21:23 GMT
George,

Its great to see Lucene.Net coming along in Apache. It's a tool that I
have used for quite some time, in various forms. There are quite a few
procedural things to get right when releasing software under the ASF. I
know it can feel quite daunting to tick all the boxes (I have had to go
through it myself). But in the long run it is best to get it all sorted
out at the start. My comments are:


As per:
http://incubator.apache.org/incubation/Incubation_Policy.html#Releases

The release artefacts must contain the "incubating" in the filename.

i.e. rather than
Lucene.Net-2.0-003-26Feb07.bin.zip

how about:
incubating-Apache-Lucene.Net-2.0-003-26Feb07.bin.zip


You cannot call the LICENSE and NOTICE files LICENSE.txt and NOTICE.txt
(I know that it makes sense under Windows). The LICENSE refers
explicitly to a NOTICE file not a NOTICE.txt. Just rename them to
LICENSE and NOTICE as used in the rest of the ASF projects.

Your NOTICE file should contain an Apache copyright statement.

You should only have 1 LICENSE and NOTICE file in the release artefact,
at the moment you have 7 of each.


In Lucene.Net-2.0-003-26Feb07.bin\src\Lucene.Net there are 2 html files
that look like they relate to the java version of Lucene. Should they be
in the release?

The binary release does not contain any documentation or API reference
is this correct? Are you intending to distribute the xml API reference
(Lucene.Net.xml) used by Visual Studio to build inline documentation?
Are you going to use NDoc to build an HTML API reference?

Your debug and release assemblies do not have any apache branding in
them at all, neither do they have embedded apache licenses etc. You
should add the LICENSE and NOTICE files as embedded resources to all of
your assemblies. This is equivalent to adding these files into the
Manifest folder of a JAR. It is also important to set the file version
to differentiate between hotfix versions.

Something like this should do:

[assembly: AssemblyVersion("X.X.X.X")]
[assembly: AssemblyInformationalVersionAttribute("X.X")]
[assembly: AssemblyFileVersion("X.X.X.X")]
[assembly: AssemblyCompany("The Apache Software Foundation")]
[assembly: AssemblyCopyright("Copyright XXXX The Apache Software
Foundation.")]
[assembly: AssemblyTrademark("Copyright XXXX The Apache Software
Foundation.")]
[assembly: AssemblyTitle("Apache Lucene.Net")]
[assembly: AssemblyDescription("The Apache Software Foundation
Lucene.Net text search library")]
[assembly: AssemblyProduct("Lucene.Net")]
[assembly: AssemblyDefaultAlias("Lucene.Net")]
[assembly: AssemblyCulture("")]

#if DEBUG
[assembly: AssemblyConfiguration("Debug")]
#else
[assembly: AssemblyConfiguration("Retail")]
#endif

Neither your debug or release assemblies have a strong name. This is
probably not a bad route to take at this point.

Your binary distribution is built against Microsoft .NET Framework 1.1
(1.0.5000.0). I don't think this is clearly documented. Is there any
reason why you have chosen to build against 1.1 rather than 1.0?

That's all that I can think of.

Cheers,
Nicko

------------
Nicko Cadell
log4net development
http://logging.apache.org/log4net


> -----Original Message-----
> From: George Aroush [mailto:george@aroush.net] 
> Sent: 05 March 2007 00:30
> To: general@incubator.apache.org
> Subject: [VOTE] Approve the release of Apache Lucene.Net 2.0 
> build 003 incubating
> 
> Hi folks,
> 
> Lucene.Net community has voted to release Lucene.Net 2.0 
> build 003 incubating.  I am emailing you to request your vote 
> for this release.
> 
> (For those who are not familiar with Lucene.Net, please visit 
> http://incubator.apache.org/lucene.net/ to learn more.)
> 
> Below are the release details.
> 
> Release history:
> https://svn.apache.org/repos/asf/incubator/lucene.net/trunk/C%
> 23/src/HISTORY
> .txt
> 
> Release artifact (source & binary):
> http://people.apache.org/~aroush/Lucene.Net-2.0-003/
> 
> Release vote history on Lucene.Net mailing list:
> http://mail-archives.apache.org/mod_mbox/incubator-lucene-net-
> dev/200702.mbo
> x/%3c118901c75a1c$30ca58e0$6501a8c0@aroushlt%3e and 
> http://mail-archives.apache.org/mod_mbox/incubator-lucene-net-
> user/200702.mb
> ox/%3c118901c75a1c$30ca58e0$6501a8c0@aroushlt%3e 
> 
> I'm asking for your vote to approve this release.
> 
> [ ] +1 Approve the release as Apache Lucene.Net 2.0.0 build 
> 003 incubating [ ] -1 Veto this release (explain why so it 
> can be addressed)
> 
> Regards,
> 
> -- George Aroush
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message