incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "George Aroush" <geo...@aroush.net>
Subject RE: [VOTE] [Retry] Approve the release of Apache Lucene.Net 2.0 build 004 incubating
Date Thu, 29 Mar 2007 01:55:18 GMT
Thanks Robert!  No, you don't have to feel bad about your +0 vote, you did
your part.

All: Please review this release and give me your vote so I can move this
release on.  At least, let me know if what Robert found is (the one file
that has old license header) is a release stopper so I can go back and
re-package the release for a new vote.

Regards,

-- George Aroush 

-----Original Message-----
From: robert burrell donkin [mailto:robertburrelldonkin@gmail.com] 
Sent: Wednesday, March 28, 2007 5:22 PM
To: general@incubator.apache.org
Subject: Re: [VOTE] [Retry] Approve the release of Apache Lucene.Net 2.0
build 004 incubating

On 3/28/07, George Aroush <george@aroush.net> wrote:
> Hi Robert,
>
> Thanks for taking your time and looking at this release.  To answer 
> your
> questions:
>
> The files *.csproj, and *.sln are the Visual Studio.NET project files 
> -- those are auto generated and thus I can't edit them outside the IDE 
> -- the same goes to the few *.cs files that you noticed as well as the 
> few *.xml and *.html files that you highlighted.

yeh

IMHO it's pretty naffy that you can't add headers but that's life, i suppose
- or at least m$

> For the file,
> https://svn.apache.org/repos/asf/incubator/lucene.net/trunk/C%23/contr
> ib/Sno wball.Net/Test/Analysis/Snowball/TestSnowball.cs where you 
> pointed out the use of the old style Apache License, it looks like 
> http://www.apache.org/legal/src-headers.html#faq-update-scripts didn't 
> do the job well here.  This is an original work -- will this issue 
> prevent a release?.

different people have different opinions :-/

(hopefully people will jump in here)

IMHO it's a judgment call. i wouldn't cut a release with any header issues
of this kind but i wouldn't -1 one either.

RAT is good at catching this kind of issue (though it will pick up a lot of
false negatives  for the XML and HTML files)

> Thanks for catching the grammatical error in the README.txt: "An MADN ..."
> I fixed it in the SVN release.
>
> Again, thanks for taking your time and looking at this release candidate.
> Please let me know if I addressed all of your questions and if I get 
> your +1 or -1 vote.

+0 due to old license

(but i feel a little bad about it)

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message