incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nolan, Edell" <Edell.No...@iona.com>
Subject RE: [VOTE] Publish Yoko M1 release
Date Fri, 06 Oct 2006 11:28:13 GMT
Comments in-line. 

I will log these issues in jira and we will get them fixed.

Thanks, Edell.

-----Original Message-----
From: robert burrell donkin [mailto:robertburrelldonkin@gmail.com] 
Sent: 05 October 2006 22:02
To: general@incubator.apache.org
Subject: Re: [VOTE] Publish Yoko M1 release

On 9/29/06, Mosur Ravi, Balaji <bravi@iona.com> wrote:
> The Yoko community voted on and has approved a proposal to release 
> Yoko Milestone 1. Pursuant to the Releases section of the Incubation 
> Policy we would now like to request the permission of the Incubator 
> PMC to publish the milestone on the Yoko Download page.

notes:

signatures and sums are look ok to me

both binary and source distributions unpack into the current directory.
it's best to unpack into a subdirectory who name is based on the release
and distribution type.

=> Sounds reasonable!

the layout of both the binary and source distributions are
unconventional. i would not have expected the content layed out in a
subdirectory. the source should be a plain export of subversion. the
convention approach would be to add NOTICE and LICENSE to
http://svn.apache.org/repos/asf/incubator/yoko/trunk/ and then export
the base tag.

http://svn.apache.org/repos/asf/incubator/yoko/tags/ is empty. tagging
is very cheap in subversion. apache releases should be tagged so that
they can be reconstructed later (if necessary).

it's big - lots of code :-)

RAT run:

missing headers:

http://svn.apache.org/repos/asf/incubator/yoko/trunk/.ruleset
http://svn.apache.org/repos/asf/incubator/yoko/trunk/build.xml
http://svn.apache.org/repos/asf/incubator/yoko/trunk/checkstyle.xml
http://svn.apache.org/repos/asf/incubator/yoko/trunk/installSunJars
http://svn.apache.org/repos/asf/incubator/yoko/trunk/installSunJars.bat
http://svn.apache.org/repos/asf/incubator/yoko/trunk/pom.xml
http://svn.apache.org/repos/asf/incubator/yoko/trunk/api/.ruleset
http://svn.apache.org/repos/asf/incubator/yoko/trunk/api/checkstyle.xml
http://svn.apache.org/repos/asf/incubator/yoko/trunk/api/pom.xml
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/checkstyle
.xml
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/pom.xml
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/main/j
ava/org/apache/yoko/bindings/corba/CorbaExceptionHelper.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/ObjectFactory.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleInOutParams.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleInOutParamsRespon
se.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleInOutParamsWithRe
turn.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleInOutParamsWithRe
turnResponse.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleInParams.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleInParamsResponse.
java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleInParamsWithRetur
n.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleInParamsWithRetur
nResponse.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleMixedParams.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleMixedParamsRespon
se.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleMixedParamsWithRe
turn.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleMixedParamsWithRe
turnResponse.java
http://svn.apache.org/repos/asf/incubator/yoko/trunk/bindings/src/test/j
ava/org/apache/schemas/yoko/idl/parammodes/TestMultipleOutParams.java

there are a number more. the raw report is at
http://people.apache.org/~rdonkin/yoko.rat. (RAT is at
http://code.google.com/p/arat/ and can be run from source but it's very
raw ATM.)

=> will log bugs for this and get it fixed.

i think that the LICENSE may be missing a credit to OMG for

the LICENSE file contains:

"
   Celtix, EPL License,

   	../etc/third-party-licenses/celtix-epl-license.txt



   Antlr, BSD License,

	../etc/third-party-licenses/antlr-bsd-license.txt



   XmlSchema, Apache License,

	../etc/third-party-licenses/apache-license.txt



   WSDL4j, Common Public License,

	../etc/third-party-licenses/wsdl4j-cpl-license.txt



   Saaj, CDDL License

	../etc/third-party-licenses/CDDL-license.txt



   JSR150, CDDL License,

	../etc/third-party-licenses/CDDL-license.txt



   JSR181, CDDL License,

	../etc/third-party-licenses/CDDL-license.txt"

i can't find the relative paths. it's usually best to include the text
of the licenses for example
http://incubator.apache.org/guides/examples/LICENSE (then the licenses
cannot get lost).

=> We created a license file for each license and then link to it - I
will check that the paths are correct.  All the licenses are in the
etc.third-party-licenses directory so they shouldn't get lost. 

may be missing a note about
http://svn.apache.org/repos/asf/incubator/yoko/trunk/yoko-spec-corba/src
/main/java/org/omg/CORBA_2_3/portable/ObjectImpl.java
  in LICENSE

=> will find the license.

the MANIFEST.MF lacks some of the recommended attributes. consider
adding

Specification-Title: XXX
Specification-Vendor: The Apache Software Foundation
Specification-Version: n.m
Implementation-Vendor-Id: org.apache
Implementation-Vendor:  The Apache Software Foundation

=> will update this - thanks.

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message