Mailing-List: contact general-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: general@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of robertburrelldonkin@gmail.com
 designates 66.249.92.172 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=BRC8PlsM0s7uOoM/qbXsT8WoTqrH6qWsxszoYxNbYjYmF5SUmM3NV1Nw1ypgLLJ/M6L2KZSbBEqKSykYCs3hghT8Ls+tbxJ7TQZTq/pAuBLGk6SMFJ36diI6Shduw19EHatJEGH59t64nAv5QednU5L+CzXhwjc6XcEYILgRRyk=
Message-ID: <f470f68e0608181517q59da08fdj861f1beddaf480d2@mail.gmail.com>
Date: Fri, 18 Aug 2006 23:17:01 +0100
From: "robert burrell donkin" <robertburrelldonkin@gmail.com>
To: general@incubator.apache.org
Subject: Re: [VOTE] approve the 4.0.2 release of ActiveMQ
In-Reply-To: <af2843cd0608171558t6731f689tbddce4204c3fbb8f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <af2843cd0608171558t6731f689tbddce4204c3fbb8f@mail.gmail.com>

On 8/17/06, Hiram Chirino <hiram@hiramchirino.com> wrote:
> In accordance with the incubator release procedure (see below) the
> Apache ActiveMQ community has voted on and approved the 4.0.2 release
> binary.
>
> We would now like to request the permission of the Incubator PMC to
> perform the release.

(i've only reviewed the source but it's late for me and i've found
some blockers so forgive me if i don't review the binary distribution
as well)

notes:

F5BA7E4F does not seem to be available from major pgp network
keyservers. see
http://www.apache.org/dev/release-signing.html#keyserver-upload

the source downloads extracts to a folder called
incubator-activemq-4.0.2. this is the same as the folder to which the
binary distribution extracts to. it's more convenient for users if
these distributions unpack to different directories. it's conventional
to use   incubator-activemq-4.0.2-src.

blockers:

missing license headers from some of the files i checked at random
gives me concerns. for example:

maven-bundle-plugin/src/main/java/org/apache/activemq/maven/BundleMojo.java

activemq-web-demo worries me: there are a lot of files without license
headers and some which have them were not created at the ASF (which is
ok but gives me concerns about the rest).

i would like to see the issue of licenses in the source tidied up
before this release ships. i haven't gone through every file but IMO
this needs to be done.

(we need a script or something to check for license headers)

- robert

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org