From general-return-6162-apmail-incubator-general-archive=incubator.apache.org@incubator.apache.org Tue Sep 20 13:43:33 2005 Return-Path: Delivered-To: apmail-incubator-general-archive@www.apache.org Received: (qmail 47734 invoked from network); 20 Sep 2005 13:43:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 20 Sep 2005 13:43:29 -0000 Received: (qmail 58195 invoked by uid 500); 20 Sep 2005 13:43:27 -0000 Delivered-To: apmail-incubator-general-archive@incubator.apache.org Received: (qmail 58097 invoked by uid 500); 20 Sep 2005 13:43:26 -0000 Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: general@incubator.apache.org Delivered-To: mailing list general@incubator.apache.org Received: (qmail 58084 invoked by uid 99); 20 Sep 2005 13:43:26 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Sep 2005 06:43:26 -0700 X-ASF-Spam-Status: No, hits=0.4 required=10.0 tests=DNS_FROM_RFC_ABUSE X-Spam-Check-By: apache.org Received: from [206.190.38.121] (HELO web50901.mail.yahoo.com) (206.190.38.121) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 20 Sep 2005 06:43:34 -0700 Received: (qmail 61045 invoked by uid 60001); 20 Sep 2005 13:43:13 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=1AnoqgiDTL1wavch8n8KIBSTx1P6+sAwNP4ysm9jTSoKZc6o/56HPmjWWLvOUzpKo/2EIlNXuh4breqfOkfW8dKby/G1uFck/Cmi+yALMtEsT1UvJsmNXGfTgOJITK+Ebz2GEdBaHGmHO7lIU4XjEZeKWVVRdhZ2cUbFMKYIXrQ= ; Message-ID: <20050920134313.61043.qmail@web50901.mail.yahoo.com> Received: from [221.135.208.88] by web50901.mail.yahoo.com via HTTP; Tue, 20 Sep 2005 06:43:13 PDT Date: Tue, 20 Sep 2005 06:43:13 -0700 (PDT) From: Rana Bhattacharyya Subject: Re: [Ftpserver] Comments on the new code To: general@incubator.apache.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N The package ftplet is the basic API required to add custom user specified ftplets. The server needs slightly modified version of these APIs. Ftplet API is somewhat fixed but server API may get changed in future. This is the reason behind this difference. The following two hierarchy will clarify this. FtpConfig <- IFtpConfig <- FtpConfigImpl FtpStatistics <- IFtpStatistics <- FtpStatisticsImpl Thanks, Rana Bhattacharyya --- Niklas Gustavsson wrote: > Hi > > why is this difference necessary? Or maybe rather, > why the need for the > I-prefix on the "internal" interfaces? > > /niklas > > /niklas > > Rana Bhattacharyya wrote: > > Hi, > > > > This is the logic behind the interface name. > > > > 1. ftplet is basic interface package which will be > > exposed to add custom ftplet. > > > > 2. The package interfaces has all the other > interfaces > > used in the server. Here all the observers will > not > > have I in front. Everything else will have I in > front. > > > > So it bolis down to > > > > 1. No observer interface will have I prefix. > > 2. No ftplet will have I prefix. > > 3. Everything else will have I prefix. > > > > Thanks, > > Rana Bhattacharyya > > > > > > --- Niklas Gustavsson > wrote: > > > > > >>Hi > >> > >>I've taken a quick look through the new code for > >>Ftpserver commited by > >>Rana. For the most of it I'm impressed and think > it > >>looks very good. I > >>do have some minor comments though: > >> > >>1. Interfaces are inconsitently named, some > starting > >>with "I", some not. > >>They are also somewhat randomly placed in > different > >>packages with some > >>in a special "interfaces" package and some not. > >>2. Logging, I'm not so sure that it's a good idea > to > >>invent our own > >>logging solution. There are plenty out there that > >>works great and are > >>highly configurable. I think the cost of > introducing > >>a dependency is > >>lower then that of writing our own logger. > >>3. There is a great need for unit tests. I'll try > to > >>work on this. > >>4. In general, the code could be brokern down into > >>more replacable parts > >>(think IoC). I'll try to work on this as well. > >> > >>Anyways, great work! > >> > >>/niklas > >> > >> > >>------------------ > >>Niklas Gustavsson > >>niklas@protocol7.com > >>http://www.protocol7.com > >> > >> > >> > > > > > --------------------------------------------------------------------- > > > >>To unsubscribe, e-mail: > >>general-unsubscribe@incubator.apache.org > >>For additional commands, e-mail: > >>general-help@incubator.apache.org > >> > >> > > > > > > > > > > > > __________________________________ > > Yahoo! Mail - PC Magazine Editors' Choice 2005 > > http://mail.yahoo.com > > > -- > ------------------ > Niklas Gustavsson > niklas@protocol7.com > http://www.protocol7.com > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > general-unsubscribe@incubator.apache.org > For additional commands, e-mail: > general-help@incubator.apache.org > > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org For additional commands, e-mail: general-help@incubator.apache.org