incubator-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Niklas Gustavsson <nik...@protocol7.com>
Subject [Ftpserver] Comments on the new code
Date Sun, 18 Sep 2005 20:06:26 GMT
Hi

I've taken a quick look  through the new code for Ftpserver commited by
Rana. For the most of it I'm impressed and think it looks very good. I
do have some minor comments though:

1. Interfaces are inconsitently named, some starting with "I", some not.
They are also somewhat randomly placed in different packages with some
in a special "interfaces" package and some not.
2. Logging, I'm not so sure that it's a good idea to invent our own
logging solution. There are plenty out there that works great and are
highly configurable. I think the cost of introducing a dependency is
lower then that of writing our own logger.
3. There is a great need for unit tests. I'll try to work on this.
4. In general, the code could be brokern down into more replacable parts
(think IoC). I'll try to work on this as well.

Anyways, great work!

/niklas


------------------
Niklas Gustavsson
niklas@protocol7.com
http://www.protocol7.com


---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org


Mime
View raw message