From sergek@lokitech.com Wed Nov 6 03:50:56 2002 Return-Path: Mailing-List: contact general-help@incubator.apache.org; run by ezmlm Delivered-To: mailing list general@incubator.apache.org Received: (qmail 58120 invoked from network); 6 Nov 2002 03:50:56 -0000 Received: from unknown (HELO beethoven.lokitech.com) (216.7.13.68) by daedalus.apache.org with SMTP; 6 Nov 2002 03:50:56 -0000 Received: from 216.181.165.37 ([216.181.165.37]) by mail.lokitech.com (JAMES SMTP Server 2.0a3-cvs) with SMTP ID 608; Tue, 5 Nov 2002 21:41:50 -0500 Message-ID: <015701c28548$097160c0$25a5b5d8@formata> From: "Serge Knystautas" To: , "Justin Erenkrantz" References: <20021106030601.F13CD1083C@pantheon.red-bean.com> Mon, 21 Oct 2002 06:2 <200211061431.11007.peter@apache.org> <2147483647.1036524951@localhost> Subject: Re: Code ownership (was Re: whoweare.html) Date: Tue, 5 Nov 2002 22:53:15 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N ----- Original Message ----- From: "Justin Erenkrantz" > --On Wednesday, November 6, 2002 2:31 PM +1100 Peter Donald > wrote: > > For example, someone submits some code that doesn't follow various > > conventions that have been established in the project. Do you tell > > the contributor - sorry can't take that till you fix it? No. > > Usually what happens is that you commit the code. Then you go > > through and fix up style/semantic/logical violations. As the > > commit messages go past the end user sees the corrections. Next > > time they are more likely to work the way the project operates. > > Nuh-uh. That's so wrong. > > You need to encourage providing feedback not doing someone else's job > for them. > > "Give a man a fish and you feed him for a day. > Teach a man how to fish and you feed him for a lifetime." > > We should be attempting to fostering communities by teaching people > the processes, not being arrogant and commiting their fixes for them. I agree with Nicola on this, and it's important that this technique isn't done in an arrogant way or in lieu of talking, feedback, and teaching. It's done simply to get contributors to realize their code has become part of a team's codebase. It helps avoid territorial issues down the road. Serge Knystautas Loki Technologies - Unstoppable Websites http://www.lokitech.com/