Mailing-List: contact flume-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flume-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2063324390828753372=="
MIME-Version: 1.0
Subject: Re: Review Request: FLUME-1240: Add version info to Flume NG
From: "Hari Shreedharan" <hshreedharan@cloudera.com>
To: "Flume" <flume-dev@incubator.apache.org>,
 "Hari Shreedharan" <hshreedharan@cloudera.com>,
 "Ralph Goers" <rgoers@apache.org>,
 "Leslin  (Hong Xiang Lin)" <leslin123@gmail.com>
Date: Fri, 29 Jun 2012 19:24:25 -0000
Message-ID: <20120629192425.10352.26234@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Hari Shreedharan" <noreply@reviews.apache.org>
References: <20120629114934.10353.71767@reviews.apache.org>
In-Reply-To: <20120629114934.10353.71767@reviews.apache.org>
Reply-To: "Hari Shreedharan" <hshreedharan@cloudera.com>

--===============2063324390828753372==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


> On June 29, 2012, 11:49 a.m., Ralph Goers wrote:
> > I am afraid I am going to have to be -1 on this fix until a) it support=
s Windows or b) FLUME-1174 is closed as wont-fix.  There are people who see=
m to be actively engaged on making the build work on Windows in that issue =
and this one just makes their job harder.
> =

> Hari Shreedharan wrote:
>     Ralph,
>     =

>     This patch makes sure the build does not fail on Windows: https://rev=
iews.apache.org/r/5665 and this does not come in the way of people working =
on FLUME-1174. I hope that you will withdraw your -1.
>     =

>     Making the same feature available on Windows will need to be taken ca=
re of by someone who is familiar with Windows batch scripting. =

>     =

>     Thanks.
>     =

>

Please feel free to review and commit the patch for FLUME-1333.


- Hari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5463/#review8745
-----------------------------------------------------------


On June 29, 2012, 5:50 a.m., Leslin  (Hong Xiang Lin) wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5463/
> -----------------------------------------------------------
> =

> (Updated June 29, 2012, 5:50 a.m.)
> =

> =

> Review request for Flume.
> =

> =

> Description
> -------
> =

> Add feature to let flume-ng get version info:
> eslin@ubtServer:/usr/lib/flume-ng/bin$ flume-ng version
> Apache Flume version: 1.2.0-incubating-SNAPSHOT
> Built-By: 1.2.0-incubating-SNAPSHOT
> =

> =

> This addresses bug FLUME-1240.
>     https://issues.apache.org/jira/browse/FLUME-1240
> =

> =

> Diffs
> -----
> =

>   bin/flume-ng 43d1766 =

>   flume-ng-core/pom.xml e4c8104 =

>   flume-ng-core/scripts/saveVersion.sh PRE-CREATION =

>   flume-ng-core/src/main/java/org/apache/flume/VersionAnnotation.java PRE=
-CREATION =

>   flume-ng-core/src/main/java/org/apache/flume/tools/VersionInfo.java PRE=
-CREATION =

>   flume-ng-core/src/test/java/org/apache/flume/tools/TestVersionInfo.java=
 PRE-CREATION =

> =

> Diff: https://reviews.apache.org/r/5463/diff/
> =

> =

> Testing
> -------
> =

> Test with:
> flume-ng version
> flume-ng agent -n agent -f /usr/lib/flume-ng/conf/flume-conf.properties
> =

> =

> Thanks,
> =

> Leslin  (Hong Xiang Lin)
> =

>


--===============2063324390828753372==--