incubator-flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Percy" <mpe...@gmail.com>
Subject Re: Review Request: FLUME-1333: Make sure saveVersion.sh does not run on Windows.
Date Fri, 29 Jun 2012 21:26:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5665/#review8763
-----------------------------------------------------------

Ship it!


+1, lgtm

- Mike Percy


On June 29, 2012, 7:17 p.m., Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5665/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 7:17 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Added a profile that runs the plugin only if the host OS is not Windows.
> 
> 
> This addresses bug FLUME-1333.
>     https://issues.apache.org/jira/browse/FLUME-1333
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/pom.xml 97fa2dd 
>   pom.xml b4a8ea1 
> 
> Diff: https://reviews.apache.org/r/5665/diff/
> 
> 
> Testing
> -------
> 
> Ran on *nix and build succeeded, and agent runs fine with version returning correctly.

> 
> On Windows build succeeds with -DskipTests due to FLUME-1174:
> 
> [INFO] Installing C:\Users\hari\flume-ng\flume-ng-tests\pom.xml to C:\Users\hari
> \.m2\repository\org\apache\flume\flume-ng-tests\1.2.0-incubating-SNAPSHOT\flume-
> ng-tests-1.2.0-incubating-SNAPSHOT.pom
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Flume ...................................... SUCCESS [59.612s]
> [INFO] Flume NG SDK ...................................... SUCCESS [4.151s]
> [INFO] Flume NG Configuration ............................ SUCCESS [2.070s]
> [INFO] Flume NG Core ..................................... SUCCESS [2.598s]
> [INFO] Flume NG Sinks .................................... SUCCESS [1.244s]
> [INFO] Flume NG HDFS Sink ................................ SUCCESS [5.818s]
> [INFO] Flume NG IRC Sink ................................. SUCCESS [1.434s]
> [INFO] Flume NG HBase Sink ............................... SUCCESS [1.837s]
> [INFO] Flume NG Channels ................................. SUCCESS [1.548s]
> [INFO] Flume NG JDBC channel ............................. SUCCESS [1.771s]
> [INFO] Flume NG Node ..................................... SUCCESS [1.726s]
> [INFO] Flume NG file-based channel ....................... SUCCESS [1.712s]
> [INFO] Flume NG file backed Memory channel ............... SUCCESS [1.681s]
> [INFO] Flume legacy Sources .............................. SUCCESS [1.250s]
> [INFO] Flume legacy Avro source .......................... SUCCESS [2.262s]
> [INFO] Flume legacy Thrift Source ........................ SUCCESS [1.682s]
> [INFO] Flume NG Clients .................................. SUCCESS [0.969s]
> [INFO] Flume NG Log4j Appender ........................... SUCCESS [1.205s]
> [INFO] Flume NG distribution ............................. SUCCESS [14.633s]
> [INFO] Flume NG Integration Tests ........................ SUCCESS [1.242s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:50.881s
> [INFO] Finished at: Fri Jun 29 12:10:42 PDT 2012
> [INFO] Final Memory: 77M/495M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Hari Shreedharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message