incubator-flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Shreedharan" <hshreedha...@cloudera.com>
Subject Re: Review Request: FLUME-1240: Add version info to Flume NG
Date Fri, 29 Jun 2012 08:06:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5463/#review8741
-----------------------------------------------------------

Ship it!


+1. Looks good to go!

I'd suggest filing a couple of follow up jiras for:
* Renaming the variable CLEAN_FLAG to something else, which suggests its purpose.
* As of now, only Java files are included in the checksum(right?). We should include all files
- the shell scripts too count as source code. We should discuss on the jira if we should consider
even the avro files etc.

- Hari Shreedharan


On June 29, 2012, 5:50 a.m., Leslin  (Hong Xiang Lin) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5463/
> -----------------------------------------------------------
> 
> (Updated June 29, 2012, 5:50 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Description
> -------
> 
> Add feature to let flume-ng get version info:
> eslin@ubtServer:/usr/lib/flume-ng/bin$ flume-ng version
> Apache Flume version: 1.2.0-incubating-SNAPSHOT
> Built-By: 1.2.0-incubating-SNAPSHOT
> 
> 
> This addresses bug FLUME-1240.
>     https://issues.apache.org/jira/browse/FLUME-1240
> 
> 
> Diffs
> -----
> 
>   bin/flume-ng 43d1766 
>   flume-ng-core/pom.xml e4c8104 
>   flume-ng-core/scripts/saveVersion.sh PRE-CREATION 
>   flume-ng-core/src/main/java/org/apache/flume/VersionAnnotation.java PRE-CREATION 
>   flume-ng-core/src/main/java/org/apache/flume/tools/VersionInfo.java PRE-CREATION 
>   flume-ng-core/src/test/java/org/apache/flume/tools/TestVersionInfo.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/5463/diff/
> 
> 
> Testing
> -------
> 
> Test with:
> flume-ng version
> flume-ng agent -n agent -f /usr/lib/flume-ng/conf/flume-conf.properties
> 
> 
> Thanks,
> 
> Leslin  (Hong Xiang Lin)
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message