Mailing-List: contact flume-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flume-dev@incubator.apache.org
Content-Type: multipart/alternative;
	boundary="===============3270276410591393103=="
MIME-Version: 1.0
Subject: Review Request: FLUME-1047: Remove apache commons dependency from
 client sdk
From: "Mike Percy" <mpercy@gmail.com>
To: "Flume" <flume-dev@incubator.apache.org>, "Mike Percy" <mpercy@gmail.com>
Date: Mon, 26 Mar 2012 20:28:54 -0000
Message-ID: <20120326202854.26431.10034@reviews.apache.org>

--===============3270276410591393103==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4488/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

Created a static utility method to do the HexDump that the LoggerSink uses =
as output for events. This lives in the core so that the SDK no longer has =
any undeclared dependencies.


This addresses bug FULME-1047.
    https://issues.apache.org/jira/browse/FULME-1047


Diffs
-----

  flume-ng-core/src/main/java/org/apache/flume/event/EventHelper.java PRE-C=
REATION =

  flume-ng-core/src/main/java/org/apache/flume/sink/LoggerSink.java f6f9d33 =

  flume-ng-core/src/test/java/org/apache/flume/event/TestEventHelper.java P=
RE-CREATION =

  flume-ng-sdk/src/main/java/org/apache/flume/event/SimpleEvent.java 909920=
6 =

  flume-ng-sdk/src/test/java/org/apache/flume/event/TestSimpleEvent.java 38=
5cb7e =


Diff: https://reviews.apache.org/r/4488/diff


Testing
-------

mvn clean package
Unpacked tarball, ran: ./bin/flume-ng node -c conf -f conf/flume-conf.prope=
rties.template -n foo
Lots of stuff dumped to stdout


Thanks,

Mike


--===============3270276410591393103==--