incubator-flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik K" <oss....@gmail.com>
Subject Re: Review Request: customizable avro flume interchange - DefaultAvroSource/DefaultAvroSink added
Date Fri, 06 Jan 2012 19:34:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3359/
-----------------------------------------------------------

(Updated 2012-01-06 19:34:06.860377)


Review request for Flume.


Changes
-------

public interface SourceEventHandler {
    List<Event> marshallFlumeEvents();
}

public interface SinkEventHandler {
    void unmarshallFlumeEvents(Object protocolObj, List<Event> batchEvents) throws AvroRemoteException;
}

provided for eventHandlers 


Summary (updated)
-------

AvroSource / AvroSink concrete classes has injectible eventHandlers (SourceEventHandler and
SinkEventHandler), to allow for diffrerent avro protocols to be sent over flume NG.  ( not
restricted to AvroSourceProtocol , as it stands today). 

Default implementation refers to AvroSourceProtocol still though.


This addresses bug FLUME-918.
    https://issues.apache.org/jira/browse/FLUME-918


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/event/SinkEventHandler.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/event/SourceEventHandler.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSink.java
1226957 
  http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java
1226957 
  http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSourceProtocolSinkHandler.java
PRE-CREATION 
  http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java
1226957 
  http://svn.apache.org/repos/asf/incubator/flume/branches/flume-728/flume-ng-core/src/main/java/org/apache/flume/source/AvroSourceProtocolImpl.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/3359/diff


Testing
-------


Thanks,

Karthik


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message