incubator-flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLUME-925) Update build infrastructure to follow Apache Maven guidelines
Date Tue, 10 Jan 2012 21:54:42 GMT

    [ https://issues.apache.org/jira/browse/FLUME-925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183622#comment-13183622
] 

jiraposter@reviews.apache.org commented on FLUME-925:
-----------------------------------------------------



bq.  On 2012-01-10 19:57:11, Ralph Goers wrote:
bq.  > Many of the child poms reference other project artifacts and specify the Flume version.
It is a better practice to declare a variable in the parent pom that declares the Flume version.
Then add a dependencyManagement section to the parent pom that defines all the Flume artifacts
with their version. Finally, remove the version in each of the subproject so they will pick
up the version from the managed dependency.

Thanks for the review Ralph. I agree with your suggestion and will udpate poms accordingly.


- Arvind


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3447/#review4302
-----------------------------------------------------------


On 2012-01-10 19:16:02, Arvind Prabhakar wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3447/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 19:16:02)
bq.  
bq.  
bq.  Review request for Flume and Prasad Mujumdar.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Also updated the release version from 1.0.0-incubating to 1.1.0-incubating-SNAPSHOT
bq.  
bq.  
bq.  This addresses bug FLUME-925.
bq.      https://issues.apache.org/jira/browse/FLUME-925
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    flume-ng-channels/flume-file-channel/pom.xml cbf30ca 
bq.    flume-ng-channels/flume-jdbc-channel/pom.xml 25061c9 
bq.    flume-ng-channels/pom.xml 84e0020 
bq.    flume-ng-core/pom.xml a2c4173 
bq.    flume-ng-dist/pom.xml 44fe4f9 
bq.    flume-ng-node/pom.xml dae20f7 
bq.    flume-ng-sinks/flume-hdfs-sink/pom.xml 05444b9 
bq.    flume-ng-sinks/pom.xml ea04e7d 
bq.    pom.xml 7ea3c98 
bq.  
bq.  Diff: https://reviews.apache.org/r/3447/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Ran full build with a clean local cache (rm -rf ~/.m2/repository/org/apache/flume). 
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Arvind
bq.  
bq.


                
> Update build infrastructure to follow Apache Maven guidelines
> -------------------------------------------------------------
>
>                 Key: FLUME-925
>                 URL: https://issues.apache.org/jira/browse/FLUME-925
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.0.0
>            Reporter: Arvind Prabhakar
>            Assignee: Arvind Prabhakar
>             Fix For: v1.1.0
>
>         Attachments: FLUME-925.patch
>
>
> Guidelines to follow:
> http://www.apache.org/dev/publishing-maven-artifacts.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message