Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8097DDFA2 for ; Fri, 7 Dec 2012 11:52:58 +0000 (UTC) Received: (qmail 9418 invoked by uid 500); 7 Dec 2012 11:52:57 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 9331 invoked by uid 500); 7 Dec 2012 11:52:57 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 9305 invoked by uid 99); 7 Dec 2012 11:52:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 11:52:57 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.212.47] (HELO mail-vb0-f47.google.com) (209.85.212.47) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 11:52:51 +0000 Received: by mail-vb0-f47.google.com with SMTP id e21so332709vbm.6 for ; Fri, 07 Dec 2012 03:52:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=B+af0iCM2TH3TnhEENzH+A0Cqu3lAfFqD87gBnUqgV4=; b=EqnyyJdogkCqLBVZaruaytOx9a8WW904/D0aSpSwdUVps+/wxpeYy0W2kgHH854MMT ZX+kpEdYCK5SsgQjjwsyBRDENC12yFpyybJmEvyNZvoEHpEK1OA1uvQ64ONnc1WYw8GG yUegikN0tq3FAlA6dHI6yiZYWVwXzmfUECTj/W1pD90pMVXdQPSnMDWfamPvivMhb0nA 9Rz8wm1uZxiPKjXXKo4ES8ggd5KpvVNTDnjoPwWlAF/VCpJM9hRBGXkAO4UWwMbtxtei HlPZMnTGy3wLBLG5AhDiDFsBTaef1/NH1bcjvIK7rsiPK4kMq+x6yq8e6M9vFfPkVeXu /2mA== MIME-Version: 1.0 Received: by 10.58.74.196 with SMTP id w4mr3658993vev.7.1354881150259; Fri, 07 Dec 2012 03:52:30 -0800 (PST) Received: by 10.58.251.36 with HTTP; Fri, 7 Dec 2012 03:52:30 -0800 (PST) In-Reply-To: References: <20121207062609.19134qrypwk420cx@franklin.liquidweb.com> Date: Fri, 7 Dec 2012 12:52:30 +0100 Message-ID: Subject: Re: [ASJS] Adjusting FalconJS output (no general discussion in this thread, please) From: Frank Wienberg To: flex-dev@incubator.apache.org Content-Type: multipart/alternative; boundary=047d7b86edf6ac91b404d041d948 X-Gm-Message-State: ALoCoQnerDUyYL5PF3imQiGLBzfo3oJPlZp6ew/dRpUQilJJVRalI7SDRbjs6vJOa608syD5C/Lq X-Virus-Checked: Checked by ClamAV on apache.org --047d7b86edf6ac91b404d041d948 Content-Type: text/plain; charset=ISO-8859-1 Sounds good to me, too. So that would mean no support for *-imports in the first iteration? It would also mean that you would even have to import classes that are implicitly imported (same package or top-level package) to have all needed goog.require() statements generated, but I think that would be okay for the time being. You would only have to add imports that cause no trouble for "normal" compilation, so you can still have a single-source-multi-target code base. This is extremely important for testing that we implement the correct semantics. On Fri, Dec 7, 2012 at 12:30 PM, Erik de Bruin wrote: > > Ok, understood but for now, I AM going to add the imports explicitly > > declared as a writer implemented method. After we get the code "looking" > > right we can worry about actual "implications" of what is written. > > Sounds like a plan. The way I understand the Closure Builder to work I > think it will clean out unused 'requires' anyway, pretty much like I > imagine the AS compilers clean out unused 'import'. Eventually we want > to write out only what we need, if only to reduce complexity and avoid > mistakes, but I agree that is not a priority at this time. > > EdB > > > > -- > Ix Multimedia Software > > Jan Luykenstraat 27 > 3521 VB Utrecht > > T. 06-51952295 > I. www.ixsoftware.nl > --047d7b86edf6ac91b404d041d948--