Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6533BDCF1 for ; Fri, 7 Dec 2012 11:26:40 +0000 (UTC) Received: (qmail 43000 invoked by uid 500); 7 Dec 2012 11:26:39 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 42877 invoked by uid 500); 7 Dec 2012 11:26:39 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 42856 invoked by uid 99); 7 Dec 2012 11:26:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 11:26:38 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [69.167.147.50] (HELO franklin.liquidweb.com) (69.167.147.50) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Dec 2012 11:26:31 +0000 Received: from localhost ([127.0.0.1]:39106) by franklin.liquidweb.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80) (envelope-from ) id 1Tgw4H-0004vt-Qj for flex-dev@incubator.apache.org; Fri, 07 Dec 2012 06:26:09 -0500 Received: from 71.181.122.158 ([71.181.122.158]) by franklin.liquidweb.com (Horde Framework) with HTTP; Fri, 07 Dec 2012 06:26:09 -0500 Message-ID: <20121207062609.19134qrypwk420cx@franklin.liquidweb.com> Date: Fri, 07 Dec 2012 06:26:09 -0500 From: Michael Schmalle To: flex-dev@incubator.apache.org Subject: Re: [ASJS] Adjusting FalconJS output (no general discussion in this thread, please) References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.8) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - franklin.liquidweb.com X-AntiAbuse: Original Domain - incubator.apache.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - teotigraphix.com X-Get-Message-Sender-Via: franklin.liquidweb.com: authenticated_id: teotigra/from_h X-Source: X-Source-Args: X-Source-Dir: X-Virus-Checked: Checked by ClamAV on apache.org Quoting Erik de Bruin : >>> [#Insert 'goog.requires()'; the equivalent of 'import' in AS] >> >> We should take care to only generate goog.requires() for imports that are >> requires is the equivalent of import. We just need import statements to >> resolve not-fully-qualified identifiers, the dependencies have to >> be tracked seperately. > > You are correct that calling it 'equivalent' has implications I didn't > mean it to have. The 'goog.require' statements (the way we use them) > help the Closure Builder figure out dependencies, which allow it to > reach the maximum level of optimisation/minification. Only the fully > qualified namespaces of classes actually referenced in the code should > be 'required'. > > I therefor suggest that we shouldn't parse the 'imports' section of > the AS class, but work from type information available during > compilation, if there is such a thing... > > EdB > Ok, understood but for now, I AM going to add the imports explicitly declared as a writer implemented method. After we get the code "looking" right we can worry about actual "implications" of what is written. Mike -- Michael Schmalle - Teoti Graphix, LLC http://www.teotigraphix.com http://blog.teotigraphix.com