From flex-dev-return-15788-apmail-incubator-flex-dev-archive=incubator.apache.org@incubator.apache.org Mon Dec 3 06:45:51 2012 Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37184D65A for ; Mon, 3 Dec 2012 06:45:51 +0000 (UTC) Received: (qmail 56881 invoked by uid 500); 3 Dec 2012 06:45:50 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 56671 invoked by uid 500); 3 Dec 2012 06:45:49 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 56601 invoked by uid 99); 3 Dec 2012 06:45:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2012 06:45:46 +0000 X-ASF-Spam-Status: No, hits=0.3 required=5.0 tests=FRT_ADOBE2,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of cyrill.zadra@gmail.com designates 209.85.220.175 as permitted sender) Received: from [209.85.220.175] (HELO mail-vc0-f175.google.com) (209.85.220.175) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Dec 2012 06:45:40 +0000 Received: by mail-vc0-f175.google.com with SMTP id fy7so1484572vcb.6 for ; Sun, 02 Dec 2012 22:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=KizYYEzlfAbnAoQadP8Y2NKDsGCOhkUmQEyfsZKSKoY=; b=RqH3P3/GqzSktOsQcN2Ab8gn7KfsEAOpdq4OgnU4z5D66CJeQKnKadLnqvsacNY8zZ QjVz4n0BrTqp8FZxgiyQ+Ischlb8fLRdOTvODFU0GudE3ptsMnwI7rMVOSsKOqlvzxpl fJlGmLvB5os8KeuLnMDZZTyMQDmJ1CHevBQWSjbigF3/8sbY6a4wWT4fMBWGzdINeMRV 71HAWqDNTVRBOF/XSsgNiK63Q2plwQptmjx9N9Em9cNIfXaXcGIqix38d8Oy/ecm+kjt 8UZC059CSfgrYH2Z11p1SFuddUt0TEvZqOZ7dS5uwjiA0VbcLfQwtZ93RjU+XJ6DlCLn WHZQ== MIME-Version: 1.0 Received: by 10.52.70.83 with SMTP id k19mr6650157vdu.89.1354517119405; Sun, 02 Dec 2012 22:45:19 -0800 (PST) Received: by 10.220.140.208 with HTTP; Sun, 2 Dec 2012 22:45:19 -0800 (PST) In-Reply-To: References: <149F8129B58B2D418508E63117D9C5419B5B4CFCC6@nambx05.corp.adobe.com> <149F8129B58B2D418508E63117D9C5419B5B4CFD89@nambx05.corp.adobe.com> <149F8129B58B2D418508E63117D9C5419B5B4CFD91@nambx05.corp.adobe.com> Date: Sun, 2 Dec 2012 22:45:19 -0800 Message-ID: Subject: Re: Falcon test failure From: Cyrill Zadra To: "flex-dev@incubator.apache.org" Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org Hey gordon So every class has now a few tests except CSSManager. But I've got still one question. Is there a specific reason why CSSCombinator doesn't extend CSSNodeBase? Cyrill On Fri, Nov 30, 2012 at 7:05 PM, Cyrill Zadra wrote: > Yes the old compiler allows both examples... so I'll commit my change > for CSSFunctionCallPropertyValue and then this last failing test will > also will turn to "Ok" :). > > On Fri, Nov 30, 2012 at 5:37 PM, Gordon Smith wrote: >> I.e., >> >> >> Button { fontFamily: 'Times Roman' } >> >> >> instead of >> >> >> Button { fontFamily: "Times Roman" } >> >> >> ? If the old compiler allowed this, Falcon should probably allow it. >> >> - Gordon >> >> -----Original Message----- >> From: Gordon Smith [mailto:gosmith@adobe.com] >> Sent: Friday, November 30, 2012 5:18 PM >> To: flex-dev@incubator.apache.org >> Subject: RE: Falcon test failure >> >> I'm not an expert on CSS syntax. Are you supposed to be able to use either double quotes or single quotes for style values? >> >> - Gordon >> >> -----Original Message----- >> From: Cyrill Zadra [mailto:cyrill.zadra@gmail.com] >> Sent: Friday, November 30, 2012 4:12 PM >> To: flex-dev@incubator.apache.org >> Subject: Re: Falcon test failure >> >> Hi Gordon >> >> Oh I forgot to comment the one line.... >> >> I exended the method getSingleArgumentFromRaw() to remove single quotes. >> But before I commit that I first wanted to ask first here on the list if this method is really supposed to do that. I'm probably too cautious in commiting ;-) >> >> So single quotes should they also be removed if they exists at the beginning and end of a rawArgument? >> >> Cyrill >> >> >> >> Am 30.11.2012 um 13:03 schrieb Gordon Smith : >> >>> @Cyril: Thanks for adding some unit tests for CSS nodes. One test, CSSFunctionCallPropertyValue_static_getSingleArgumentFromRaw(), is failing for me. It's expecting "Test" but getting "'Test'". >>> >>> Does it pass for you? >>> >>> - Gordon