incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: Apache Flex 4.9 Release Candidate 3
Date Thu, 20 Dec 2012 07:46:10 GMT
For the TextInput test, I guess I would add a small fudge factor maybe like
this:

method="value=Number(application.textInput.alpha.toFixed(1)) + 0.003"

Or maybe the better solution is to find an alpha value that is a power of 2.
It might be more like 0.125.

On 12/19/12 11:11 PM, "Frédéric THOMAS" <webdoublefx@hotmail.com> wrote:

> Hi,
>
> Thanks for this info, I didn't noticed the old FP gave that kind of output
> when used with toFixed(0) and internaly, the
> falsh.globalization.CurrencyFormatter use toFixed(0) for the
> fractionalDigits property, which is logical anyway.
>
> An other one :
> [1] I would use a rounded value because the <AssertMethodValue
> method="value=Number(application.textInput.alpha.toFixed(1))" value="0.1" />
> use toFixed and the real alpha is 0.09765625
>
> What do you think ?
> (Sorry, I need to get familiar with those tests and for that, need to ask
> you many things, at term, it could be good hopefully because, I'll be able
> to fix them without help)
>
> - Fred
>
> [1] gumbo/components/TextInput/Properties/TextInput_properties_tester
> Gumbo_TextInput_alpha_property_01 Failed AssertMethodValue (method cannot be
> shown)(body:step 1)  method returned 0, expected 0.100000
>
> -----Message d'origine-----
> From: Alex Harui
> Sent: Thursday, December 20, 2012 7:51 AM
> To: flex-dev@incubator.apache.org
> Subject: Re: Apache Flex 4.9 Release Candidate 3
>
> It appears that in more recent players:
>     Number(0.12345).toFixed(0)
> returns "0"
> But older players returns "0."
> Which is probably a bug (the "." following the "0" that they fixed.
>
> For these tests, since they are AssertMethodValue, I would change the method
> expression to add a "." if it is missing.  Maybe something like:
>
> var s:String = application.cf_inline.format(...); value = (s.indexOf(".") ==
> -1) ? s + "." : s;
>
>
> On 12/19/12 10:09 PM, "Frédéric THOMAS" <webdoublefx@hotmail.com> wrote:
>
>> @Alex,
>>
>> Do you think the expected value is good  ?
>>
>> <AssertMethodValue method="value=application.cf_inline.format(0.12345)"
>>                                valueExpression="value='RUR0.'"/>
>>
>> I think the valueExpression should be  "value='RUR0'" because the
>> fractionalDigits is set to 0, so to me, the result "RUR0" is good.
>>
>> - Fred
>>
>> -----Message d'origine-----
>> From: Frédéric THOMAS
>> Sent: Thursday, December 20, 2012 6:16 AM
>> To: flex-dev@incubator.apache.org
>> Subject: Re: Apache Flex 4.9 Release Candidate 3
>>
>> Arff, I'm mixing everything, I shouldn't do that at 6 AM :P
>>
>> -----Message d'origine-----
>> From: Frédéric THOMAS
>> Sent: Thursday, December 20, 2012 6:13 AM
>> To: flex-dev@incubator.apache.org
>> Subject: Re: Apache Flex 4.9 Release Candidate 3
>>
>> But it seems normal to me that the format method removes the decimal
>> separator when there's no decimal part.
>>
>> -----Message d'origine-----
>> From: Frédéric THOMAS
>> Sent: Thursday, December 20, 2012 6:08 AM
>> To: flex-dev@incubator.apache.org
>> Subject: Re: Apache Flex 4.9 Release Candidate 3
>>
>> Oups, that's the opposite, the expected is "0." and the result is "0".
>>
>> -----Message d'origine-----
>> From: Frédéric THOMAS
>> Sent: Thursday, December 20, 2012 5:52 AM
>> To: flex-dev@incubator.apache.org
>> Subject: Re: Apache Flex 4.9 Release Candidate 3
>>
>> Hi,
>>
>> I was looking at the CurrencyFormatter and seen that if the value is set
>> to
>> "0.12345.", the expected result is "0" but only when the value start by
>> "0.", the format method return "0.", with an other numbers, the decimal
>> separator disapear but not with 0, it's at least what's the fail tests
>> shown, do you agree, same for you ?
>>
>> - Fred
>>
>> -----Message d'origine-----
>> From: Alex Harui
>> Sent: Thursday, December 20, 2012 5:42 AM
>> To: flex-dev@incubator.apache.org
>> Subject: Re: Apache Flex 4.9 Release Candidate 3
>>
>> I am not getting the BubbleProperties failure, or the fxg failures on my
>> 11.5 Windows run, but I did get the Image_styles_smoothingQuality,
>> TextInput_properties_tester, and CurrencyFormatter errors.  I am going to
>> look into the CurrencyFormatter errors now.  Then the TextInput test.
>>
>>
>> On 12/19/12 7:40 PM, "Frédéric THOMAS" <webdoublefx@hotmail.com> wrote:
>>
>>> Waoou, never open the results.txt before, very usefull, thanks.
>>>
>>> =====================================================
>>>     Failed:
>>> =====================================================
>>> components/Charts/Bubble/Properties/BubbleProperties
>>> BubbleSeries_multipleAxes_disabledDays Failed CompareBitmap(body:step 1)
>>> compare returned[object BitmapData]
>>> gumbo/components/Image/styles/Image_styles_smoothingQuality
>>> Image_Scale_stretch_smoothingQuality_high Failed CompareBitmap(body:step
>>> 6)
>>> compare returned[object BitmapData]
>>> gumbo/components/TextInput/Properties/TextInput_properties_tester
>>> Gumbo_TextInput_alpha_property_01 Failed AssertMethodValue (method cannot
>>> be
>>> shown)(body:step 1)  method returned 0, expected 0.100000
>>> spark/core/fxg/properties/fxgtemplate_tester filters_filters_blend Failed
>>> CompareBitmap(body:step 1)  compare returned[object BitmapData]
>>> spark/core/fxg/properties/fxgtemplate_tester scale9_bitmapgraphic_scale9
>>> Failed CompareBitmap(body:step 1)  compare returned[object BitmapData]
>>> spark/core/fxg/properties/fxgtemplate_tester
>>> scale9_shape_bmpgraphic_scalegridgroup Failed CompareBitmap(body:step 1)
>>> compare returned[object BitmapData]
>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>
>
CF_Fallback_format_currencyISOCode_default_currencySymbol_default_declaration>>
>
> s
>>> _test1
>>> Failed AssertMethodValue (method cannot be shown)(body:step 3)  method
>>> returned USD0, expected USD0.
>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>> CF_Fallback_format_modify_different_properties_test4 Failed
>>> AssertMethodValue (method cannot be shown)(body:step 3)  method returned
>>> RUR0, expected RUR0.
>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>> CF_Fallback_format_modify_different_properties_test5 Failed
>>> AssertMethodValue (method cannot be shown)(body:step 3)  method returned
>>> RUR0, expected RUR0.
>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>> CF_Fallback_format_modify_different_properties_test6 Failed
>>> AssertMethodValue (method cannot be shown)(body:step 3)  method returned
>>> RUR0, expected RUR0.
>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>> CF_Fallback_format_modify_different_properties_test7 Failed
>>> AssertMethodValue (method cannot be shown)(body:step 3)  method returned
>>> RUR0, expected RUR0.
>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>> CF_Fallback_format_modify_different_properties_test14 Failed
>>>
>
AssertMethodValue%20%28method%20cannot%20be%20shown%29%28body%3Astep%203%29%2>>
>
> 0
>>> %20method%20returned%20%u20AC0%2C%20expected%20%u20AC0.
>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>
>
CF_Fallback_format_currencyISOCode_default_currencySymbol_default_script_test>>
>
> 1
>>> 5
>>> Failed AssertMethodValue (method cannot be shown)(body:step 3)  method
>>> returned USD0, expected USD0.
>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>> CF_Fallback_format_currencyISOCode_CNY_currencySymbol_valid_script_test16
>>> Failed AssertMethodValue (method cannot be shown)(body:step 3)  method
>>> returned CNY0, expected CNY0.
>>>
>>> - Fred.
>>>
>>> -----Message d'origine-----
>>> From: Carol Frampton
>>> Sent: Wednesday, December 19, 2012 5:30 PM
>>> To: flex-dev@incubator.apache.org
>>> Subject: Re: Apache Flex 4.9 Release Candidate 3
>>>
>>> Then if they are bitmap compare failures you can use
>>> mustella/as3/src/mustella/ImageDiffAIR.air to look at the bitmap
>>> differences.  Or were the first couple timeouts?  The screen after your
>>> run or the bottom of results.txt would have this information.
>>>
>>> Carol
>>>
>>> On 12/19/12 11 :20AM, "Frédéric THOMAS" <webdoublefx@hotmail.com> wrote:
>>>
>>>> Hi Carol,
>>>>
>>>> Already done and it gave me less than before but I just did it again and
>>>> gave me 14, once again and gave me 14 too [1].
>>>>
>>>> - Fred.
>>>>
>>>> [1]
>>>> components/Charts/Bubble/Properties/BubbleProperties
>>>> BubbleSeries_multipleAxes_disabledDays
>>>> gumbo/components/Image/styles/Image_styles_smoothingQuality
>>>> Image_Scale_stretch_smoothingQuality_high
>>>> gumbo/components/TextInput/Properties/TextInput_properties_tester
>>>> Gumbo_TextInput_alpha_property_01
>>>> spark/core/fxg/properties/fxgtemplate_tester filters_filters_blend
>>>> spark/core/fxg/properties/fxgtemplate_tester scale9_bitmapgraphic_scale9
>>>> spark/core/fxg/properties/fxgtemplate_tester
>>>> scale9_shape_bmpgraphic_scalegridgroup
>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>>
>>>> CF_Fallback_format_currencyISOCode_default_currencySymbol_default_declarat
>>>> ions_test1
>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>> CF_Fallback_format_modify_different_properties_test4
>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>> CF_Fallback_format_modify_different_properties_test5
>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>> CF_Fallback_format_modify_different_properties_test6
>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>> CF_Fallback_format_modify_different_properties_test7
>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>> CF_Fallback_format_modify_different_properties_test14
>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>>
>>>> CF_Fallback_format_currencyISOCode_default_currencySymbol_default_script_t
>>>> est15
>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tester
>>>> CF_Fallback_format_currencyISOCode_CNY_currencySymbol_valid_script_test16
>>>>
>>>> -----Original Message-----
>>>> From: Carol Frampton [mailto:cframpto@adobe.com]
>>>> Sent: Wednesday, December 19, 2012 5:10 PM
>>>> To: flex-dev@incubator.apache.org
>>>> Subject: Re: Apache Flex 4.9 Release Candidate 3
>>>>
>>>>
>>>>
>>>> On 12/19/12 11 :05AM, "Frédéric THOMAS" <webdoublefx@hotmail.com>
wrote:
>>>>
>>>>> Running Mustella tests on the develop branch - FP11.4 / AIR3.4 / en_US
>>>>>
>>>>> 1- ant -> build success
>>>>> 2- ant other.locales -> build success
>>>>> 3- ant checkintests -> pass
>>>>> 4- sh mini_run.sh -all -> Fails: 16 [1] (some of them [2] are probably
>>>>> relative to the locale and/or String comparison)
>>>>
>>>> at this point you should run "./mini_run.sh -failures -rerun" and at
>>>> least the first 6 under [1] should/may go away.
>>>>
>>>> Carol
>>>>
>>>>>
>>>>> Well, I haven't got the time today for analyzing and maybe fix these
>>>>> failed tests but tomorrow yes I guess.
>>>>>
>>>>> - Fred
>>>>>
>>>>> [1]
>>>>> components/Charts/Bubble/Properties/BubbleProperties
>>>>> BubbleSeries_multipleAxes_disabledDays
>>>>> gumbo/components/Image/styles/Image_styles_smoothingQuality
>>>>> Image_Scale_stretch_smoothingQuality_high
>>>>> gumbo/components/TextInput/Properties/TextInput_properties_tester
>>>>> Gumbo_TextInput_alpha_property_01
>>>>> spark/core/fxg/properties/fxgtemplate_tester filters_filters_blend
>>>>> spark/core/fxg/properties/fxgtemplate_tester
>>>>> scale9_bitmapgraphic_scale9
>>>>> spark/core/fxg/properties/fxgtemplate_tester
>>>>> scale9_shape_bmpgraphic_scalegridgroup
>>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tes
>>>>> ter
>>>>>
>>>>> CF_Fallback_format_currencyISOCode_default_currencySymbol_default_decla
>>>>> rat
>>>>> ions_test1
>>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tes
>>>>> ter
>>>>> CF_Fallback_format_modify_different_properties_test4
>>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tes
>>>>> ter
>>>>> CF_Fallback_format_modify_different_properties_test5
>>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tes
>>>>> ter
>>>>> CF_Fallback_format_modify_different_properties_test6
>>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tes
>>>>> ter
>>>>> CF_Fallback_format_modify_different_properties_test7
>>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tes
>>>>> ter
>>>>> CF_Fallback_format_modify_different_properties_test14
>>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tes
>>>>> ter
>>>>>
>>>>> CF_Fallback_format_currencyISOCode_default_currencySymbol_default_scrip
>>>>> t_t
>>>>> est15
>>>>> spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_format_Main_tes
>>>>> ter
>>>>>
>>>>> CF_Fallback_format_currencyISOCode_CNY_currencySymbol_valid_script_test
>>>>> 16
>>>>>
>>>>> [2]
>>>>> RESULT:
>>>>> scriptName=spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_form
>>>>> at_
>>>>> Main_tester
>>>>> id=CF_Fallback_format_currencyISOCode_default_currencySymbol_default_de
>>>>> cla
>>>>> rations_test1 result=fail elapsed=187 phase=body started=1355932292064
>>>>> extraInfo=null msg=AssertMethodValue (method cannot be shown)(body:step
>>>>> 3)  method returned USD0, expected USD0.
>>>>> RESULT:
>>>>> scriptName=spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_form
>>>>> at_ Main_tester id=CF_Fallback_format_modify_different_properties_test4
>>>>> result=fail elapsed=250 phase=body started=1355932292913 extraInfo=null
>>>>> msg=AssertMethodValue (method cannot be shown)(body:step 3)  method
>>>>> returned RUR0, expected RUR0.
>>>>> RESULT:
>>>>> scriptName=spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_form
>>>>> at_ Main_tester id=CF_Fallback_format_modify_different_properties_test6
>>>>> result=fail elapsed=340 phase=body started=1355932293573 extraInfo=null
>>>>> msg=AssertMethodValue (method cannot be shown)(body:step 3)  method
>>>>> returned RUR0, expected RUR0.
>>>>> RESULT:
>>>>> scriptName=spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_form
>>>>> at_ Main_tester id=CF_Fallback_format_modify_different_properties_test7
>>>>> result=fail elapsed=280 phase=body started=1355932293963 extraInfo=null
>>>>> msg=AssertMethodValue (method cannot be shown)(body:step 3)  method
>>>>> returned RUR0, expected RUR0.
>>>>> RESULT:
>>>>> scriptName=spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_form
>>>>> at_ Main_tester
>>>>> id=CF_Fallback_format_modify_different_properties_test14
>>>>> result=fail elapsed=297 phase=body started=1355932296744 extraInfo=null
>>>>> msg=AssertMethodValue (method cannot be shown)(body:step 3)  method
>>>>> returned €0, expected €0.
>>>>> RESULT:
>>>>> scriptName=spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_form
>>>>> at_
>>>>> Main_tester
>>>>> id=CF_Fallback_format_currencyISOCode_default_currencySymbol_default_sc
>>>>> rip
>>>>> t_test15 result=fail elapsed=171 phase=body started=1355932297072
>>>>> extraInfo=null msg=AssertMethodValue (method cannot be shown)(body:step
>>>>> 3)  method returned USD0, expected USD0.
>>>>> RESULT:
>>>>> scriptName=spark/formatters/CurrencyFormatter/Fallback/CF_Fallback_form
>>>>> at_
>>>>> Main_tester
>>>>> id=CF_Fallback_format_currencyISOCode_CNY_currencySymbol_valid_script_t
>>>>> est
>>>>> 16 result=fail elapsed=253 phase=body started=1355932297290
>>>>> extraInfo=null msg=AssertMethodValue (method cannot be shown)(body:step
>>>>> 3)  method returned CNY0, expected CNY0.
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: Alex Harui [mailto:aharui@adobe.com]
>>>>> Sent: Wednesday, December 19, 2012 8:26 AM
>>>>> To: flex-dev@incubator.apache.org
>>>>> Subject: Re: Apache Flex 4.9 Release Candidate 3
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On 12/18/12 11:19 PM, "Frédéric THOMAS" <webdoublefx@hotmail.com>
>>>>> wrote:
>>>>>
>>>>>> Hi Alex,
>>>>>>
>>>>>> BTW, "Avertissement" means Warning.
>>>>>
>>>>> Yup, BabelFish is amazing.  I learned something today!
>>>>>
>>>>> --
>>>>> Alex Harui
>>>>> Flex SDK Team
>>>>> Adobe Systems, Inc.
>>>>> http://blogs.adobe.com/aharui
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui
>>
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>

--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui

Mime
View raw message