incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cyrill Zadra <cyrill.za...@gmail.com>
Subject Re: [Falcon] Unit tests failing
Date Tue, 11 Dec 2012 10:13:59 GMT
Hey

There is a new class EnvProperties that holds all the important
variables as FLEX_HOME, FLASH_DEBUGGER .. I didn't know where the to
put that class to.. so it's in the src/utils folder at the moment.

EnvProperties loads the properties from unittest.properties. If it
doesn't exists it tries the environement variables and then it sets a
default value:

SDK = "../compiler/generated/dist/sdk";
FPSDK = "../compiler/generated/dist/sdk/frameworks/libs/player";

Updated all 3 base test class MXMLFeatureTestsBase, SDKSWCTests and
MXMLNodeBaseTests and they can be used now with unittest.properties.

So I hope I'm not going to destroy your dev setup no.. but I can say I
tested it with eclipse and just ant and it worked in both directions.

Cyrill

On Mon, Dec 10, 2012 at 11:22 AM, Gordon Smith <gosmith@adobe.com> wrote:
> And I'm not blocked by this.
>
> - Gordon
>
> -----Original Message-----
> From: Gordon Smith
> Sent: Monday, December 10, 2012 11:21 AM
> To: flex-dev@incubator.apache.org
> Subject: RE: [Falcon] Unit tests failing
>
> They're not yet run by 'ant tests'. I just run them in Eclipse. But I'm planning to add
them to Ant soon.
>
> - Gordon
>
> -----Original Message-----
> From: Alex Harui [mailto:aharui@adobe.com]
> Sent: Monday, December 10, 2012 10:56 AM
> To: flex-dev@incubator.apache.org
> Subject: Re: [Falcon] Unit tests failing
>
> OK.  Are the feature tests in the ant build?  I think they aren't so they didn't break
so I didn't notice them.
>
> I've got to deal with some mustella issues, then I'll get to this unless you are completely
blocked.  I think you aren't if you copy the sdk.
>
>
> On 12/10/12 10:27 AM, "Gordon Smith" <gosmith@adobe.com> wrote:
>
>> You only made the unit-tests work with a unittest.properties file. I
>> think the feature-tests need a similar fix. I don't particularly want
>> to have multiple .properties file that have to be configured. Can you
>> please make one, perhaps at the level of the falcon directory, that can be used by
both projects?
>>
>> Also, can you please update the Falcon README to explain the .properties file?
>>
>> - Gordon
>>
>> -----Original Message-----
>> From: Alex Harui [mailto:aharui@adobe.com]
>> Sent: Friday, December 07, 2012 9:01 PM
>> To: flex-dev@incubator.apache.org
>> Subject: Re: [Falcon] Unit tests failing
>>
>>
>>
>>
>> On 12/7/12 4:56 PM, "Gordon Smith" <gosmith@adobe.com> wrote:
>>
>>> It is unacceptable to have to configure every debug config you create.
>>> I create dozens per day when I work on Falcon.
>> Agreed.
>>
>> After reading up on it, it appears that there is no way to set new
>> defaults for every individual junit test in Eclipse.  So I implemented
>> one
>> suggestion: instead of environment variables or system properties, the
>> tests will read a compiler.tests/unittest.properties file with
>> FLEX_HOME and PLAYERGLOBAL_HOME specified in it.  If you don't have
>> the file or don't specify the variables, it will default to the
>> compiler/generated/dist/sdk that copy.sdk would create.
>>
>>>
>>> - Gordon
>>>
>>> -----Original Message-----
>>> From: omuppi1@gmail.com [mailto:omuppi1@gmail.com] On Behalf Of Om
>>> Sent: Friday, December 07, 2012 4:40 PM
>>> To: flex-dev@incubator.apache.org
>>> Subject: Re: [Falcon] Unit tests failing
>>>
>>> In Eclipse:
>>>
>>> Under 'Run' menu > Select "Debug Configurations..."
>>> On the left, right-click "JUnit" > Select "New"
>>> When the New Configuration is created, you can customize pretty much
>>> everything you want:
>>>
>>> Try playing with the settings in one of these tabs:
>>> * Arguments
>>> * Environment
>>>
>>> HTH
>>>
>>> Thanks,
>>> Om
>>>
>>> On Fri, Dec 7, 2012 at 4:00 PM, Gordon Smith <gosmith@adobe.com> wrote:
>>>
>>>>> Can this really be possible that there is no place to configure
>>>>> Junit's
>>>> runtime environment from within Eclipse?
>>>>
>>>> I looked in the workspace preferences dialog under Run/Debug >
>>>> Launching but didn't see a way to do anything useful.
>>>>
>>>> - Gordon
>>>>
>>>> -----Original Message-----
>>>> From: Alex Harui [mailto:aharui@adobe.com]
>>>> Sent: Friday, December 07, 2012 3:52 PM
>>>> To: flex-dev@incubator.apache.org
>>>> Subject: Re: [Falcon] Unit tests failing
>>>>
>>>>
>>>>
>>>>
>>>> On 12/7/12 3:48 PM, "Gordon Smith" <gosmith@adobe.com> wrote:
>>>>
>>>>> And it should NOT require any voodoo to launch Eclipse, such as a
>>>>> launch script.
>>>> Agreed
>>>>>
>>>>> I would be able to tolerate it requiring a one-time setup in the
>>>>> Eclipse workspace, but I can't find any place to configure
>>>>> environment variables there.
>>>> Can this really be possible that there is no place to configure
>>>> Junit's runtime environment from within Eclipse?
>>>>>
>>>>> - Gordon
>>>>>
>>>>>
>>>>> -----Original Message-----
>>>>> From: Gordon Smith [mailto:gosmith@adobe.com]
>>>>> Sent: Friday, December 07, 2012 3:45 PM
>>>>> To: flex-dev@incubator.apache.org
>>>>> Subject: RE: [Falcon] Unit tests failing
>>>>>
>>>>> All unit tests (at least for Falcon) should be zero-configuration.
>>>>> You open up a file like MXMLArrayTagTests.java. You double-click
>>>>> the name of an individual test you want to debug, such as the first
>>>>> one, MXMLArrayTag_empty(), to select it. Then you right-click on it
>>>>> and choose Debug As > JUnit Test from the context menu. It should
>>>>> just work. The default debug configuration that gets created for
>>>>> this test needs to be sufficient without any additional Program
>>>>> Arguments or VM
>>>> Arguments.
>>>>>
>>>>> - Gordon
>>>>>
>>>>> -----Original Message-----
>>>>> From: Alex Harui [mailto:aharui@adobe.com]
>>>>> Sent: Friday, December 07, 2012 3:36 PM
>>>>> To: flex-dev@incubator.apache.org
>>>>> Subject: Re: [Falcon] Unit tests failing
>>>>>
>>>>> The copy.sdk target is still in there if you need it.
>>>>>
>>>>> But first, wow do you use the unit tests from Eclipse?  I've never
>>>>> tried it, I always use the command line.  Do you set up a run
>>>>> config of some sort?  If you set a FLEX_HOME in the config's
>>>>> environment does
>>>> that work?
>>>>>
>>>>> Once I understand how you use Eclipse I will try to get it to work.
>>>>>
>>>>>
>>>>> On 12/7/12 3:27 PM, "Gordon Smith" <gosmith@adobe.com> wrote:
>>>>>
>>>>>> After trying and failing to do any Falcon work today, I'll keep
>>>>>> complaining about this. The unit tests are no longer working in
>>>>>> Eclipse. I get
>>>>>>
>>>>>> command line
>>>>>> Error: unable to open
>>>>>> 'D:\Apache\incubator\flex\falcon\trunk\compiler\generated\dist\sdk
>>>>>> \
>>>>>> fr
>>>>>> a
>>>>>> meworks\
>>>>>> mxml-2009-manifest.xml'.
>>>>>>
>>>>>> command line
>>>>>> Error: unable to open
>>>>>> 'D:\Apache\incubator\flex\falcon\trunk\compiler\generated\dist\sdk
>>>>>> \
>>>>>> fr
>>>>>> a
>>>>>> meworks\
>>>>>> libs\player\11.1\playerglobal.swc'.
>>>>>>
>>>>>> This is presumably because the SDK is no longer being copied into
>>>>>> a place that the unit tests can find them. The unit tests can't
>>>>>> use an environment variable to find them because it is infeasible
>>>>>> to specify that environment every time you want to make an Eclipse
>>>>>> debug config for a particular unit test.
>>>>>>
>>>>>> Is there some way to make this work in Eclipse that I don't know
>>>>>> about, so that every JUnit test "just work" without having to
>>>>>> customize a run-config or debug-config for it?
>>>>>>
>>>>>> If not, I will restore some ant targets to do the SDK copying.
>>>>>> Alex may not want to use them, but I need to.
>>>>>>
>>>>>> - Gordon
>>>>>>
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Gordon Smith
>>>>>> Sent: Thursday, December 06, 2012 2:58 PM
>>>>>> To: flex-dev@incubator.apache.org
>>>>>> Subject: RE: [Falcon] Unit tests failing
>>>>>>
>>>>>> OK, then I'll stop complaining.
>>>>>>
>>>>>> - Gordon
>>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Alex Harui [mailto:aharui@adobe.com]
>>>>>> Sent: Thursday, December 06, 2012 1:59 PM
>>>>>> To: flex-dev@incubator.apache.org
>>>>>> Subject: Re: [Falcon] Unit tests failing
>>>>>>
>>>>>> The versions in compiler/commandline already looked for FLEX_HOME
>>>>>> environment variable.
>>>>>>
>>>>>>
>>>>>> On 12/6/12 1:56 PM, "Gordon Smith" <gosmith@adobe.com> wrote:
>>>>>>
>>>>>>> I should have said Falcon's 'mxmlc' and 'compc' shell scripts.
>>>>>>>
>>>>>>> - Gordon
>>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: Gordon Smith
>>>>>>> Sent: Thursday, December 06, 2012 1:55 PM
>>>>>>> To: flex-dev@incubator.apache.org
>>>>>>> Subject: RE: [Falcon] Unit tests failing
>>>>>>>
>>>>>>> So, how does Falcon's 'asc' shell script do its job? Did you
make
>>>>>>> it use an environment variable to find an SDK?
>>>>>>>
>>>>>>> - Gordon
>>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: Alex Harui [mailto:aharui@adobe.com]
>>>>>>> Sent: Thursday, December 06, 2012 1:40 PM
>>>>>>> To: flex-dev@incubator.apache.org
>>>>>>> Subject: Re: [Falcon] Unit tests failing
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 12/6/12 12:57 PM, "Gordon Smith" <gosmith@adobe.com>
wrote:
>>>>>>>
>>>>>>>> But doesn't it make it impossible to use Falcon's shell scripts,
>>>>>>>> which expect to find other things in the SDK using relative
>>>>>>>> paths from those shell scripts???
>>>>>>> You mean like the mxmlc and compc scripts?  They take a FLEX_HOME
>>>>>>> environment variable and seem to be working.
>>>>>>>>
>>>>>>>> Falcon isn't going to be independent of the SDK in the sense
of
>>>>>>>> being external to it. The goal is for it to replace the old
>>>>>>>> compiler
>>>>>>>> *in* the SDK. I don't want to be polluting an SDK with Falcon
>>>>>>>> until it is ready, but it made sense to me to copy whatever
SDK
>>>>>>>> you want test Falcon with into Falcon's directory, so that
>>>>>>>> everything is relative to each other as it will eventually
be.
>>>>>>>>
>>>>>>> I guess I haven't given up on the vision of Falcon being so
>>>>>>> independent that it doesn't have to be in every SDK release.
 For
>>>>>>> sure, I am currently working on a "new SDK" and I want Falcon
and
>>>>>>> FalconJS to work with it.  I want to finish the vision of not
>>>>>>> having to change Falcon for every version of the SDK.
>>>>>>> That would eventually allow the SDK folder to not contain any
>>>>>>> java code, and changing SDK versions becomes a matter of changing
>>>>>>> SWCs and not JARs.
>>>>>>>
>>>>>>> And I don't want to eliminate the possibility that someone will
>>>>>>> take on the effort to integrate Falcon into an IDE.
>>>>>>>
>>>>>>> --
>>>>>>> Alex Harui
>>>>>>> Flex SDK Team
>>>>>>> Adobe Systems, Inc.
>>>>>>> http://blogs.adobe.com/aharui
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Alex Harui
>>>>>> Flex SDK Team
>>>>>> Adobe Systems, Inc.
>>>>>> http://blogs.adobe.com/aharui
>>>>>>
>>>>>
>>>>> --
>>>>> Alex Harui
>>>>> Flex SDK Team
>>>>> Adobe Systems, Inc.
>>>>> http://blogs.adobe.com/aharui
>>>>>
>>>>
>>>> --
>>>> Alex Harui
>>>> Flex SDK Team
>>>> Adobe Systems, Inc.
>>>> http://blogs.adobe.com/aharui
>>>>
>>>>
>>
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui
>>
>
> --
> Alex Harui
> Flex SDK Team
> Adobe Systems, Inc.
> http://blogs.adobe.com/aharui
>

Mime
View raw message