incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chema Balsas <jbal...@gmail.com>
Subject Re: svn commit: r1423863 - /incubator/flex/sdk/branches/develop/frameworks/projects/charts/src/mx/charts/DateTimeAxis.as
Date Wed, 19 Dec 2012 22:32:36 GMT
Ok, I'll be reverting them shortly, and definitely being more careful in
the future...

BTW, in regard of the whitespace/new lines... do we have a coding style
document in the wiki to follow?

Sorry again for the trouble.

Cheers,
Chema

2012/12/19 Gordon Smith <gosmith@adobe.com>

> I think these are Falcon bugs.
>
> - Gordon
>
> -----Original Message-----
> From: Chema Balsas [mailto:jbalsas@gmail.com]
> Sent: Wednesday, December 19, 2012 1:57 PM
> To: flex-dev@incubator.apache.org
> Subject: Re: svn commit: r1423863 -
> /incubator/flex/sdk/branches/develop/frameworks/projects/charts/src/mx/charts/DateTimeAxis.as
>
> >
> > What was the type of d, the type of v, and the type of parseFunction?
>
>
> d was Date, v was object, and  for parseFunction there was
>
> override public function set parseFunction(value:Function):void
> {
>     super.parseFunction = value;
> }
>
>
> What is the type of newStyles? Is styleFunction of type Function?
>
>
> The same case... newStyles is Object, for styleFunction there is
>
> override public function set styleFunction(value:Function):void
> {
>     super.styleFunction = value;
> }
>
>
> 2012/12/19 Gordon Smith <gosmith@adobe.com>
>
> > What is the type of newStyles? Is styleFunction of type Function?
> >
> > - Gordon
> >
> >
> > -----Original Message-----
> > From: Chema Balsas [mailto:jbalsas@gmail.com]
> > Sent: Wednesday, December 19, 2012 12:47 PM
> > To: flex-dev@incubator.apache.org
> > Subject: Re: svn commit: r1423863 -
> > /incubator/flex/sdk/branches/develop/frameworks/projects/charts/src/mx
> > /charts/DateTimeAxis.as
> >
> > The error in OLAPDatagrid.as was
> >
> > Error: Implicit coercion of a value of type IOLAPAxisPosition to an
> > > unrelated type Function.
> > >             newStyles = styleFunction(rowPosn, colPosn, cellValue);
> > >                                       ^
> >
> >
> > Both may be related with a setter with that name being defined in the
> > same class.
> >
> > @Gordon is this something you'll be taking care of inside Falcon? I'll
> > revert these two, in that case...
> >
> > Cheers,
> > Chema
> >
> > 2012/12/19 Carol Frampton <cframpto@adobe.com>
> >
> > > svn commit: r1423864 looks like it falls in the same category and
> > > should be reverted
> > >
> > > Carol
> > >
> > >
> > >
> > > On 12/19/12 3 :07PM, "Justin Mclean" <justin@classsoftware.com> wrote:
> > >
> > > >HI,
> > > >
> > > >> +        var parseFunction:Function = this.parseFunction;
> > > >
> > > >
> > > >Wouldn't it be better to fix Flacon rather than change the SDK in
> > > >this way? Seems a bit hackish to me.
> > > >
> > > >Thanks,
> > > >Justin
> > > >
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message