incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chema Balsas <jbal...@gmail.com>
Subject Re: svn commit: r1423863 - /incubator/flex/sdk/branches/develop/frameworks/projects/charts/src/mx/charts/DateTimeAxis.as
Date Wed, 19 Dec 2012 22:06:16 GMT
>
> The policy should be to not change valid and correct AS code in the SDK
> just
> because Falcon cannot compile it.  There will be times when we will change
> the SDK code because Falcon is stricter than MXMLC, but I don't think these
> changes fall into that category.


I've already left some issues waiting for Gordon to comment on wether
they're Falcon bugs or not. I may have misjugded these. As I saw similar
code in place I assumed it was a safe change. I'll be reverting them soon.
Is it okay to wait to see if Gordon can confirm this as a Falcon bug, or do
you prefer it to be reverted right away and then brought in later if not?

Sorry for the inconvenience everyone.

Cheers,
Chema

2012/12/19 Chema Balsas <jbalsas@gmail.com>

> What was the type of d, the type of v, and the type of parseFunction?
>
>
> d was Date, v was object, and  for parseFunction there was
>
> override public function set parseFunction(value:Function):void
> {
>     super.parseFunction = value;
> }
>
>
> What is the type of newStyles? Is styleFunction of type Function?
>
>
> The same case... newStyles is Object, for styleFunction there is
>
> override public function set styleFunction(value:Function):void
> {
>     super.styleFunction = value;
> }
>
>
> 2012/12/19 Gordon Smith <gosmith@adobe.com>
>
>> What is the type of newStyles? Is styleFunction of type Function?
>>
>> - Gordon
>>
>>
>> -----Original Message-----
>> From: Chema Balsas [mailto:jbalsas@gmail.com]
>> Sent: Wednesday, December 19, 2012 12:47 PM
>> To: flex-dev@incubator.apache.org
>> Subject: Re: svn commit: r1423863 -
>> /incubator/flex/sdk/branches/develop/frameworks/projects/charts/src/mx/charts/DateTimeAxis.as
>>
>> The error in OLAPDatagrid.as was
>>
>> Error: Implicit coercion of a value of type IOLAPAxisPosition to an
>> > unrelated type Function.
>> >             newStyles = styleFunction(rowPosn, colPosn, cellValue);
>> >                                       ^
>>
>>
>> Both may be related with a setter with that name being defined in the
>> same class.
>>
>> @Gordon is this something you'll be taking care of inside Falcon? I'll
>> revert these two, in that case...
>>
>> Cheers,
>> Chema
>>
>> 2012/12/19 Carol Frampton <cframpto@adobe.com>
>>
>> > svn commit: r1423864 looks like it falls in the same category and
>> > should be reverted
>> >
>> > Carol
>> >
>> >
>> >
>> > On 12/19/12 3 :07PM, "Justin Mclean" <justin@classsoftware.com> wrote:
>> >
>> > >HI,
>> > >
>> > >> +        var parseFunction:Function = this.parseFunction;
>> > >
>> > >
>> > >Wouldn't it be better to fix Flacon rather than change the SDK in
>> > >this way? Seems a bit hackish to me.
>> > >
>> > >Thanks,
>> > >Justin
>> > >
>> >
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message