incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chema Balsas <jbal...@gmail.com>
Subject Re: svn commit: r1423863 - /incubator/flex/sdk/branches/develop/frameworks/projects/charts/src/mx/charts/DateTimeAxis.as
Date Wed, 19 Dec 2012 23:02:50 GMT
>
> Since this is old code without a lot of tests behind in, in this case the
> best practice would be to touch as little code as possible.


I agree... I did ran a full mustella pass though, to be sure, before
committing. I assume not even that is enough then, and that some parts of
code may be uncovered, right?

2012/12/19 Carol Frampton <cframpto@adobe.com>

>
>
> On 12/19/12 5 :40PM, "Justin Mclean" <justin@classsoftware.com> wrote:
>
> >Hi,
> >
> >> I don't think that's the right change.  I'm guessing the intent is to
> >>change
> >> a local variable, not the instance's height property?
> >
> >
> >Nice catch. Calling a variable the same as a local property is probably a
> >bad idea. Best fix here I think would be to rename height to something
> >else?
>
>
> Since this is old code without a lot of tests behind in, in this case the
> best practice would be to touch as little code as possible.
>
> Carol
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message