incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicholas Kwiatkowski <nicho...@spoon.as>
Subject Re: Working towards a 4.9 Release Candidate
Date Wed, 05 Dec 2012 12:51:44 GMT
I'm the one who committed the changes to the code.

They were minor, and don't effect the display, nor really the operation of
the component.  They simply prevent the lifecycle from being run multiple
times.  I think all of four lines were changed in the commit.

I've personally been using them in my production code for the last three
weeks (and I built a quick mustella test around them, but that didn't get
committed, because it really isn't comprehensive enough).

-Nick

On Wed, Dec 5, 2012 at 3:52 AM, Omar Gonzalez <omarg.developer@gmail.com>wrote:

> On Wednesday, December 5, 2012, Justin Mclean wrote:
>
> > Hi,
> >
> > > I am sorry, but it does not make sense to release something that has
> not
> > been tested.
> > Again I agree but we have to live with what we have. I'm sure that the
> the
> > tests we currently have do not provide 100% coverage.
> >
> > > It is an entirely different issue to not test it at all.
> > As I said we did exactly that with the previous release (for charts).
> >
> > Justin
>
>
> The previous release was a parity release, no code changes in charts
> therefore tests weren't important.
>
> This time around, what Om is saying, there are changes and we have tests.
> It would be dumb not to use them.
>
> -omar
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message