incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik de Bruin <e...@ixsoftware.nl>
Subject Re: [ASJS] Adjusting FalconJS output (no general discussion in this thread, please)
Date Fri, 07 Dec 2012 15:19:36 GMT
Closer ;-)

I'll list all my little nags, I hope I don't start to bore you or
unnecessarily repeat myself.

- I'm still seeing the public property from AS back instead of the
private var in the constructor, without a @type annotation, but with a
/* : type hint */
- the private var seems to have gone completely;
- the goog.base call should be the first line in the constructor function;
- the @extends annotation should have curly brackets around the type:
@extends {flash.display.Sprite}
- I'm missing the semi colons after the last curly bracket of a function block;
- there are some whitespace issues (this is where the nagging gets
real bad, sorry):
    - in the second and third JSDoc blocks there is an extra line
    - the opening curly brackets of a function block should be on the
same line as the function keyword and behind the arguments, separated
by one (1) space
- personally, I would get rid of the 'Member' and 'Method' lines in
the JSDoc blocks, they don't provide useful information, they merely
state the name of the item, which is clearly readable a few short
lines later ;-)

EdB


On Fri, Dec 7, 2012 at 4:01 PM, Michael Schmalle
<apache@teotigraphix.com> wrote:
> Ok next iteration;
>
> - I'm working on the constructor block right now so that private var isn't
> showing up yet.
> - As far as I have seen that was the only lagging issue from the last post.
>
> Are the tags and stuff correct?
>
>
>
> //---------------------------------------------------------
> JS CODE
>
>
> /**
>  * CROSS-COMPILED BY MXMLJSC (329449.1) ON 2012-12-07 09:57:20
>  */
>
> goog.provide("com.example.components.MyTextButton");
>
> goog.require("flash.display.Sprite");
>
> /**
>
>  * @constructor
>  * @extends flash.display.Sprite
>  */
> com.example.components.MyTextButton = function()
> {
>                 this.publicProperty /* : Number */ = 100;
>                 goog.base(this);
> }
>
> goog.inherits(com.example.components.MyTextButton, flash.display.Sprite);
>
> /**
>
>  * Member: com.example.components.MyTextButton.publicProperty
>  * @type {number}
>  */
> com.example.components.MyTextButton.prototype.publicProperty = 100;
>
>
>
> /**
>  * Method: com.example.components.MyTextButton.myFunction()
>  * @this {com.example.components.MyTextButton}
>  * @param {string} value
>  * @return {string}
>  */
> com.example.components.MyTextButton.prototype.myFunction = function(value)
>
> {
>                 return (("Don't " + this._privateVar) + value);
> }
>
>
> //--------------------------------------------------------------
>
>
> Mike
>
>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Mime
View raw message