Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flex-dev@incubator.apache.org
Date: Thu, 18 Oct 2012 19:04:04 +0000 (UTC)
From: "Carol Frampton (JIRA)" <jira@apache.org>
To: flex-dev@incubator.apache.org
Message-ID: <1524658148.65139.1350587044469.JavaMail.jiratomcat@arcas>
In-Reply-To: <1206216298.9337.1343984404573.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (FLEX-33156) focusInHandler() in spark Scroller
 doesn't null check focusManager property before using
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/FLEX-33156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479251#comment-13479251 ] 

Carol Frampton commented on FLEX-33156:
---------------------------------------

I believe your change was so you have an extra check in there.  Also I was suggesting you use fm for both the "if (fm)" and latter for "fm.getFocus()".

        var fm:IFocusManager = focusManager;
        if (fm)
	{
		if (isOurFocus(DisplayObject(event.target)))
		{
		        // When we gain focus, make sure the focused element is visible
		        if (viewport && ensureElementIsVisibleForSoftKeyboard)
		        {
		                var elt:IVisualElement = focusManager.getFocus() as IVisualElement; 
		                lastFocusedElement = elt;
		        }
		}
	}

                
> focusInHandler() in spark Scroller doesn't null check focusManager property before using
> ----------------------------------------------------------------------------------------
>
>                 Key: FLEX-33156
>                 URL: https://issues.apache.org/jira/browse/FLEX-33156
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Spark: Scroller
>    Affects Versions: Adobe Flex SDK 4.6 (Release)
>            Reporter: Roland Zwaga
>             Fix For: Adobe Flex SDK Next
>
>         Attachments: Scroller.as.patch
>
>
> the focusHandler() method wrongfully assumes that the focusManager is always a valid instance. When checking the focusManager property in UIComponent it is clear that in certain cases this property can return a null value.
> So in some cases this can lead to an RTE. I have encountered this once in my current project but find it very hard to reproduce. Basically a Scroller instance that was displayed in a popup window gave this RTE after the popup was removed.
> Reproducable or not, I believe the null check should be added seeing the fact that the focusManager property explicitly returns null in some cases.
> I have attached a patch file which adds the null check.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira