incubator-flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Fisher <dave2w...@comcast.net>
Subject Re: InstallApacheFlex - Can you please test the build script?
Date Fri, 07 Sep 2012 05:53:44 GMT

On Sep 6, 2012, at 8:49 PM, Om wrote:

> On Thu, Sep 6, 2012 at 5:08 PM, Dave Fisher <dave2wave@comcast.net> wrote:
> 
>> 
>> On Sep 6, 2012, at 2:46 PM, Om wrote:
>> 
>>> Carol,
>>> 
>>> I have incorporated all your change requests.  Please take a look again
>>> when you get a chance.   You might want to clarify some wording in the
>>> READme file as you may think fit.
>>> 
>>> Sometimes the rat report complains about generated files (ex.
>> build.number)
>>> even though I explicitly exclude it from the rat ant task.  Not sure what
>>> to do about this issue.  I thought the rat.report is just a guideline,
>>> right?  I guess we can just ignore this?
>> 
>> The rat report is an important tool. It is especially important when the
>> codebase is large. When I review a release package I will want to
>> understand what is in the excludes file and why. Be mindful of wildcards.
>> I'll look at exceptions individually. If there are a large number I won't
>> and then I'll let you know why.
>> 
>> Regards,
>> Dave
>> 
>> 
> Dave,
> 
> I think I understand the importance of the rat report.  Am I correct in my
> assumption that the rat report tool does not check for license headers on
> generated files?  The "build.number" is one such file that I have added to
> the list of exclusions.  The rat tool seems to ignore this exclusion and
> ends up complaining about the file.
> 
> I am not sure how to handle this situation.

How many files does it warn you about? Only a few or hundreds. If it is a few don't worry
about it. If hundreds then we should look now, but I'm not sure when I'll have time before
the middle of next week. Someone else may have time too.

Regards,
Dave

> 
> Thanks,
> Om
> 
> 
> 
>> 
>>> 
>>> Thanks,
>>> Om
>>> 
>>> On Wed, Sep 5, 2012 at 8:17 AM, Carol Frampton <cframpto@adobe.com>
>> wrote:
>>> 
>>>> Om,
>>>> 
>>>> It builds fine.
>>>> 
>>>> Your rat.report is not clean.
>>>> 
>>>> I still don't think the source kit is organized correctly.
>>>> 
>>>> When I unzip the source directory I see the subdirectories
>>>> 
>>>> common
>>>> installer
>>>> 
>>>> There is no README.  I happen to know it is in installer so I cd to
>>>> installer and read the README.  There are still no instructions on how
>> to
>>>> build the source with ant.  The instructions on how to build with
>>>> FlashBuilder don't count.
>>>> 
>>>> I expect to see something like to build the source type
>>>> 
>>>>       ant -DFLEX_HOME=/path/to/apache/flex/sdk
>>>> -DAIR_HOME=/path/to/air/sdk
>>>> 
>>>> or alternatively define each of these as environment variables and/or
>> edit
>>>> build.properties.
>>>> 
>>>> I expect to see something to the effect that the output can be found in
>>>> the installer/release directory.
>>>> 
>>>> Carol
>>>> 
>>>> On 9/4/12 7 :02PM, "Om" <bigosmallm@gmail.com> wrote:
>>>> 
>>>>> On Tue, Sep 4, 2012 at 7:49 AM, Carol Frampton <cframpto@adobe.com>
>>>> wrote:
>>>>> 
>>>>>> Why are the OpenSans fonts duplicated in the installer and common
>> asset
>>>>>> directories?
>>>>>> 
>>>>>> 
>>>>> You are right, they are redundant.  I have removed the ones under
>>>>> installer.
>>>>> 
>>>>> I also fixed the build issue that you ran into earlier as well.
>>>>> 
>>>>> Please retry when you get a chance.
>>>>> 
>>>>> Thanks,
>>>>> Om
>>>>> 
>>>>> 
>>>>> 
>>>>>> Carol
>>>>>> 
>>>>>> On 9/1/12 4 :29AM, "Om" <bigosmallm@gmail.com> wrote:
>>>>>>> 
>>>>>>> On Fri, Aug 31, 2012 at 6:12 PM, Om <bigosmallm@gmail.com>
wrote:
>>>>>>> 
>>>>>>>> I discovered a bug in the ant script where the fixcrlf task
was
>>>>>> messing
>>>>>>>> up
>>>>>>>> the font and png files.  I have fixed it by exluding these
file
>> types
>>>>>>>> while
>>>>>>>> running that task.
>>>>>>>> 
>>>>>>>> Omar, I am pretty sure that this would fix your issues.
>>>>>>>> 
>>>>>>>> I am calling this vote off now.  I will be putting up a new
set of
>>>>>>>> artifacts that should hopefully fix all the issues raised
in this
>>>>>>>> thread.
>>>>>>>> 
>>>>>>>> Thanks,
>>>>>>>> Om
>>>>>> 
>>>>>> 
>>>> 
>>>> 
>> 
>> 


Mime
View raw message