From flex-dev-return-10473-apmail-incubator-flex-dev-archive=incubator.apache.org@incubator.apache.org Fri Aug 3 18:42:08 2012 Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D48F5D7B0 for ; Fri, 3 Aug 2012 18:42:08 +0000 (UTC) Received: (qmail 63483 invoked by uid 500); 3 Aug 2012 18:42:06 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 63452 invoked by uid 500); 3 Aug 2012 18:42:06 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 63421 invoked by uid 99); 3 Aug 2012 18:42:06 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2012 18:42:06 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.213.47] (HELO mail-yw0-f47.google.com) (209.85.213.47) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2012 18:41:59 +0000 Received: by yhjj56 with SMTP id j56so1104426yhj.6 for ; Fri, 03 Aug 2012 11:41:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:x-gm-message-state; bh=HMqG1BVTn+KGB5iUa0ccH269aynsEo/xOaE/QxPk+4U=; b=M13S+u4jL8PiQJGBGnvqEV8CO58SVIc77/DsLbJWqtJK3JxMhkV9Cyn55EzbCqrY5m +EbX8/rv6mgB9M+ngjdJ8a2Y23EacmLW7X4pi2miuoQmcVsfT8wT1iYGfA0W1zbiYuql DrPn1+r7UZ4m3auscXvZKxPIe4T23ISsAZw3DpE9xPvTlZRfDT4aPRGQN9YfNiViphoI LSZ0rkiMSuw9Q80c7Sr789uX9egdIFewlTTjJEHbCvHxSG88tVIiRH9pI2+kKyfcwdAB XSIV5gwBouCdea5Ilbefvw5UGoSwY3zvRuaeIsN1ttZAD5KkBFbuxUTgmJyOkMWCZepG iqJw== MIME-Version: 1.0 Received: by 10.50.154.232 with SMTP id vr8mr12339207igb.2.1344019298397; Fri, 03 Aug 2012 11:41:38 -0700 (PDT) Received: by 10.64.76.7 with HTTP; Fri, 3 Aug 2012 11:41:38 -0700 (PDT) In-Reply-To: References: Date: Fri, 3 Aug 2012 20:41:38 +0200 Message-ID: Subject: Re: Erik de Bruin's patch for FLEX-33149 and FLEX-33150 From: Erik de Bruin To: flex-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlHVQEQTQkCyMrgnwRYGS1wDzjN+Arb7F80MChWp1eGkbxmYrfrW3nu287et2vA0XojOypR > 1. I see your comment about moving URL_CONFIG_XML constant from > ViewResourceConstants to the main class. Resource constants dont > necessarily have to be localizable strings. It can be urls, icons, sound > files etc. I dont think such constants should be in the main class > itself. IMHO it makes it inconsistent. > A good compromise would be place this constant in the ViewResourceConstants > class, but NOT load it as a locale string using iResourceManager . Would > that be acceptable? I like compromises ;-) Done. > 2. You have added a few log mesasges. Can you please convert them into > locale strings for the en_US locale at least? This will make it easier for > other locale contributors to provide corresponding translations. Done. Should have done that in the first place, but I forgot, sorry. While I was at it, I also prepare a solution to smooth out the whole localization process a bit. Once this patch lands, we can take a look at it, if you're interested. > 3. When verifying the Apache Flex SDK MD5 signature, a message is being > logged for every progress update which causes a ton of log messages . You > probably can just log when the verification starts and when it ends. Done. > 4. A log message about the result of the verification of the Apache Flex > SDK would be good. Especially true when the md5 check fails and we abort, > we need to let the user know what just happened. Done. > 5. Not a huge deal, but if possible, in the sequence of logs, can we make > sure that the Version number log is always the first one? Can you point me in the right direction, I can't find where it is logged at the moment... > 6. For some reason, the 'temp' folder is not getting deleted after the > install. This used to work. Can you please debug and see if you > introduced something that causes this issue? I'm unable to reproduce... maybe it's a 'Windows' thing (I'm on a Mac)? > 7. In the fetchApacheMirrorFromCGI() method, the result handler to > _internetUtil.fetch is specified to be the same method - > fetchApacheMirrorFromCGI() This method is a bit too confusing. I think it > will be better if you had a separate event handler where you process the > result and extract the url. Done. > 8. Can you move all the mirror fetching logic into one class and provide a > common api? The internal logic can be abstracted from the main class. Done. > I hope you dont mind fixing the patch based on these comments and > reattaching it when you get a chance. I can then commit this patch to > svn. I've added the new patch to FLEX-33106. EdB -- Ix Multimedia Software Jan Luykenstraat 27 3521 VB Utrecht T. 06-51952295 I. www.ixsoftware.nl P.S. I would like everybody to know that as of this morning I broke my personal record for days lived.